KEMBAR78
Make spin_op.distribute_terms batch more efficiently by bmhowe23 · Pull Request #1437 · NVIDIA/cuda-quantum · GitHub
Skip to content

Conversation

@bmhowe23
Copy link
Collaborator

Resolves #1434

@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Mar 24, 2024
The new test_spin_op_random() test shows that sometimes
cudaq.SpinOperator.random() isn't generating enough terms in the return
value. This was traced down to duplicates being created, but since the
final spin op stores everything in an unordered_map, the duplicates were
being silently eliminated.
@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Mar 25, 2024
Copy link
Collaborator

@amccaskey amccaskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@bmhowe23 bmhowe23 enabled auto-merge (squash) March 25, 2024 20:18
@bmhowe23 bmhowe23 merged commit db855fa into NVIDIA:main Mar 25, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 25, 2024
@bmhowe23 bmhowe23 deleted the pr-fix-i1434 branch March 25, 2024 21:23
@bettinaheim bettinaheim added enhancement New feature or request performance labels Apr 17, 2024
@bettinaheim bettinaheim added this to the release 0.7.1 milestone Apr 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request performance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

distribute_terms does not batch efficiently

3 participants