Fix LLVM aarch64 relocation overflow #1444
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Diffs originated from llvm/llvm-project#71968 and were modified to target the specific version of LLVM in use by CUDA Quantum (16.0.6).
|
Note: need to revert when LLVM is rebased. |
That PR hasn't been merged in upstream LLVM yet, so we may need to rebase it (assuming this works in the first place). |
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
bmhowe23
had a problem deploying
to
ghcr-deployment
GitHub Actions
Failure
bmhowe23
had a problem deploying
to
ghcr-deployment
GitHub Actions
Failure
bmhowe23
had a problem deploying
to
ghcr-deployment
GitHub Actions
Failure
bmhowe23
had a problem deploying
to
ghcr-deployment
GitHub Actions
Failure
bmhowe23
had a problem deploying
to
ghcr-deployment
GitHub Actions
Failure
bmhowe23
had a problem deploying
to
ghcr-deployment
GitHub Actions
Failure
bmhowe23
had a problem deploying
to
ghcr-deployment
GitHub Actions
Failure
bmhowe23
had a problem deploying
to
ghcr-deployment
GitHub Actions
Failure
bmhowe23
had a problem deploying
to
ghcr-deployment
GitHub Actions
Failure
bmhowe23
had a problem deploying
to
ghcr-deployment
GitHub Actions
Failure
bmhowe23
had a problem deploying
to
ghcr-deployment
GitHub Actions
Failure
bmhowe23
had a problem deploying
to
ghcr-deployment
GitHub Actions
Failure
bmhowe23
temporarily deployed
to
ghcr-deployment
GitHub Actions
Inactive
bmhowe23
temporarily deployed
to
ghcr-deployment
GitHub Actions
Inactive
bmhowe23
temporarily deployed
to
ghcr-deployment
GitHub Actions
Inactive
bmhowe23
temporarily deployed
to
ghcr-deployment
GitHub Actions
Inactive
bmhowe23
temporarily deployed
to
ghcr-deployment
GitHub Actions
Inactive
bmhowe23
temporarily deployed
to
ghcr-deployment
GitHub Actions
Inactive
bmhowe23
temporarily deployed
to
ghcr-deployment
GitHub Actions
Inactive
bmhowe23
temporarily deployed
to
ghcr-deployment
GitHub Actions
Inactive
bmhowe23
temporarily deployed
to
ghcr-deployment
GitHub Actions
Inactive
bmhowe23
temporarily deployed
to
ghcr-deployment
GitHub Actions
Inactive
bmhowe23
temporarily deployed
to
ghcr-deployment
GitHub Actions
Inactive
bmhowe23
temporarily deployed
to
ghcr-deployment
GitHub Actions
Inactive
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
Hopefully this gets merged upstream fairly soon so this will just be fixed out of the box. |
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1421
#1421 appears similar to llvm/llvm-project#71963, which is possibly fixed by llvm/llvm-project#71968.
The diffs in this PR originated from llvm/llvm-project#71968 and were modified to target the specific version of LLVM in use by CUDA Quantum (16.0.6). We also changed the default value of ReserveAlloc from false to true.
I did some UCCSD timings with and without this change on x86 / H100's, nvidia-fp64 simulator. The table below is an average of 10 runs. All times are in seconds.
The 12 qubit case is the only one that looks noticeably worse, and that one appeared to have large run-to-run variance (32ms - 138ms).