KEMBAR78
Allow measurement of variadic list of qubits by amccaskey · Pull Request #1502 · NVIDIA/cuda-quantum · GitHub
Skip to content

Allow measurement of variadic list of qubits #1502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 24, 2024
Merged

Allow measurement of variadic list of qubits #1502

merged 1 commit into from
Apr 24, 2024

Conversation

@amccaskey
Copy link
Collaborator

Fixes #1498

@copy-pr-bot
Copy link

copy-pr-bot bot commented Apr 11, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@amccaskey
Copy link
Collaborator Author

amccaskey commented Apr 15, 2024 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@amccaskey amccaskey enabled auto-merge (squash) April 15, 2024 18:31
@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Apr 15, 2024
@cuda-quantum-bot
Docs preview for PR #1502.
172ddf9
@amccaskey amccaskey requested a review from schweitzpgi April 15, 2024 23:51
bmhowe23
bmhowe23 approved these changes Apr 24, 2024
View reviewed changes
Copy link
Collaborator

@bmhowe23 bmhowe23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Alex. FWIW, I also double checked that the C++ interface behaves similarly (i.e. mz(q[0], q[1]) behaves similar to your test).

@amccaskey
Allow measurement of variadic list of qubits
fa66be2 
Signed-off-by: Alex McCaskey <amccaskey@nvidia.com>
@amccaskey
Copy link
Collaborator Author

amccaskey commented Apr 24, 2024 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@amccaskey amccaskey merged commit 77507a0 into NVIDIA:main Apr 24, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Apr 24, 2024
@bettinaheim bettinaheim added the bug fix To be listed under Bug Fixes in the release notes label Apr 30, 2024
@bettinaheim bettinaheim added this to the release 0.7.1 milestone Apr 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@bmhowe23 bmhowe23 bmhowe23 approved these changes

@khalatepradnya khalatepradnya Awaiting requested review from khalatepradnya

@schweitzpgi schweitzpgi Awaiting requested review from schweitzpgi

Assignees

No one assigned

Labels

bug fix To be listed under Bug Fixes in the release notes

Projects

None yet

Milestone

release 0.7.1

Development

Successfully merging this pull request may close these issues.

Output discrepancy when args of mz are in a list vs when comma separated

3 participants

@amccaskey @bmhowe23 @bettinaheim