KEMBAR78
Fix issue with indexing raw args pointer for return value by amccaskey · Pull Request #1540 · NVIDIA/cuda-quantum · GitHub
Skip to content

Fix issue with indexing raw args pointer for return value #1540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 18, 2024
Merged

Fix issue with indexing raw args pointer for return value #1540

merged 2 commits into from
Apr 18, 2024

Conversation

@amccaskey
Copy link
Collaborator

Fixes #1529

@amccaskey
Fix issue with indexing raw args pointer for return value
0e9565d 
Signed-off-by: Alex McCaskey <amccaskey@nvidia.com>
@copy-pr-bot
Copy link

copy-pr-bot bot commented Apr 18, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@amccaskey
Copy link
Collaborator Author

amccaskey commented Apr 18, 2024 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Apr 18, 2024
@cuda-quantum-bot
Docs preview for PR #1540.
4ca0be7
@amccaskey
list vs List got me
af497bf 
Signed-off-by: Alex McCaskey <amccaskey@nvidia.com>
@amccaskey
Copy link
Collaborator Author

amccaskey commented Apr 18, 2024 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Apr 18, 2024
@cuda-quantum-bot
Docs preview for PR #1540.
91bdfdb
@amccaskey amccaskey enabled auto-merge (squash) April 18, 2024 18:25
annagrin
annagrin approved these changes Apr 18, 2024
View reviewed changes
Copy link
Collaborator

@annagrin annagrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Alex!

@amccaskey amccaskey merged commit 41ed0d1 into NVIDIA:main Apr 18, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Apr 18, 2024
@bettinaheim bettinaheim added the bug fix To be listed under Bug Fixes in the release notes label Apr 30, 2024
@bettinaheim bettinaheim added this to the release 0.7.1 milestone Apr 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@annagrin annagrin annagrin approved these changes

@khalatepradnya khalatepradnya Awaiting requested review from khalatepradnya

@bmhowe23 bmhowe23 Awaiting requested review from bmhowe23

Assignees

No one assigned

Labels

bug fix To be listed under Bug Fixes in the release notes

Projects

None yet

Milestone

release 0.7.1

Development

Successfully merging this pull request may close these issues.

Calling kernel functions with list parameters gives incorrect results

3 participants

@amccaskey @annagrin @bettinaheim