Fixes and issue with sampling when kernel contains mid-circuit measurements #1619
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current Python `MidCircuitMeasurementAnalyzer` visitor only supports certain expressions, e.g., `if val` but not `if val == True`, where `val = mz(q)`. Hence, it mis-identified some kernels as non-measurement feedback, i.e., not setting `qubitMeasurementFeedback=true`, causing wrong sampling mode being used. This PR: - Add more handling cases: variable name or variable subscript; CompareOp; handle variables in BoolOp and UnaryOp. - Add IR checks and target tests. Note: this is not an exhaustive handling of all possible scenarios.
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
|
IMO, this analysis shouldn't really be done on the AST. Can you create another issue to replace this ad hoc pattern matching with a dataflow analysis? (We need it for C++ as well.) |
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
bettinaheim
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current Python
MidCircuitMeasurementAnalyzervisitor only supports certain expressions, e.g.,if valbut notif val == boolVar, whereval = mz(q).Hence, it may mis-identify some kernels as non-measurement feedback, i.e., not setting
qubitMeasurementFeedback=true, causing wrong sampling mode being used.This PR:
Add more handling cases: variable name or variable subscript;
CompareOp; handle variables inBoolOpandUnaryOp.Add IR checks and target tests.
Note: this is not an exhaustive handling of all possible scenarios.
Resolves #1618