-
Notifications
You must be signed in to change notification settings - Fork 294
Blochsphere Visualization #1763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
CLA Assistant Lite bot All Contributors have signed the CLA. |
|
I have read the Contributor License Agreement and I hereby accept the Terms. |
|
recheck |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution. This is looking good.
Recommend the following enhancements for completeness:
- Please add a unit test that can check the newly added APIs. You can add to existing suite in this file - https://github.com/NVIDIA/cuda-quantum/blob/main/python/tests/kernel/test_kernel_features.py
- Add a notebook example to showcase the functionality. You can edit this - https://github.com/NVIDIA/cuda-quantum/blob/main/docs/sphinx/examples/python/tutorials/quantum_bits.ipynb. (It currently has an image of Bloch sphere.)
|
Can you add screenshots to this PR of how the output will look like for - (a) one Bloch sphere, (b) side by side rendering of multiple Bloch spheres? |
|
For CI failures:
|
|
Added functionality in the latest commit:
|
|
Implemented @amccaskey 's suggestion: If |
|
Thanks for the updates and addressing review comments. |
|
Hi, a comment from my work on #1723 : I am introducing a folder |
|
@freifrauvonbleifrei Absolutely! I had used the name |
Fixed docstrings in python/cudaq/visualization/bloch_visualize.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates. Requesting changes on spell check.
@prateekchawla168 I had chosen |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution.
One open Q in comments.
CI failure will be addressed separately (see 6328008)
Command Bot: Processing... |
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
Command Bot: Processing... |
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
|
@prateekchawla168: Please add a comment on the issue #1639 so it can be assigned to you. |
Command Bot: Processing... |
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
image so that it available to run the new functionality out-of-the-box. Also addresses the CI failure on notebook validation.
Command Bot: Processing... |
-- updated toml file to reflect qutip<5 -- updated notebook to use default target (optionally set 'density-matrix-cpu') -- removed redundant comments and fixed one occurence of 'CUDA-Q'
Command Bot: Processing... |
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |



Description
Fixes #1639 by adding a visualization for Bloch sphere for single-qubit states.
Significant changes:
This is a submission for Unitary Hack 2024.
I have read the Contributor License Agreement and I hereby accept the Terms.