KEMBAR78
Address scoping issue for `sample_async` by khalatepradnya · Pull Request #1878 · NVIDIA/cuda-quantum · GitHub
Skip to content

Address scoping issue for sample_async #1878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 3, 2024
Merged

Address scoping issue for sample_async #1878

merged 7 commits into from
Jul 3, 2024

Conversation

@khalatepradnya
Copy link
Collaborator

Fix for #1218

@khalatepradnya khalatepradnya requested a review from amccaskey July 1, 2024 21:53
@khalatepradnya khalatepradnya self-assigned this Jul 1, 2024
@khalatepradnya @amccaskey
[Bug-fix] [Python] Address scoping issue reported in NVIDIA#1218
8ef2682 
---------

Co-authored-by: Alex McCaskey <amccaskey@nvidia.com>
@khalatepradnya khalatepradnya requested a review from bmhowe23 July 1, 2024 21:56
@khalatepradnya khalatepradnya added this to the release 0.8.0 milestone Jul 1, 2024
@khalatepradnya khalatepradnya added bug fix To be listed under Bug Fixes in the release notes python-lang Anything related to the Python CUDA Quantum language implementation labels Jul 1, 2024
github-actions bot pushed a commit that referenced this pull request Jul 1, 2024
@cuda-quantum-bot
Docs preview for PR #1878.
545907b
@github-actions
Copy link

github-actions bot commented Jul 1, 2024

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

@github-actions
Copy link

github-actions bot commented Jul 1, 2024

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Jul 1, 2024
@cuda-quantum-bot
Docs preview for PR #1878.
accabed
@khalatepradnya khalatepradnya linked an issue Jul 2, 2024 that may be closed by this pull request
Out of scope kernel #1218
Closed
3 tasks
@khalatepradnya khalatepradnya enabled auto-merge (squash) July 2, 2024 00:12
@github-actions
Copy link

github-actions bot commented Jul 2, 2024

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Jul 2, 2024
@cuda-quantum-bot
Docs preview for PR #1878.
d1e4c97
@khalatepradnya khalatepradnya requested a review from 1tnguyen July 2, 2024 20:41
@github-actions
Copy link

github-actions bot commented Jul 2, 2024

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Jul 2, 2024
@cuda-quantum-bot
Docs preview for PR #1878.
c1d02fc
github-actions bot pushed a commit that referenced this pull request Jul 2, 2024
@cuda-quantum-bot
Docs preview for PR #1878.
30c583d
@github-actions
Copy link

github-actions bot commented Jul 2, 2024

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

bmhowe23
bmhowe23 approved these changes Jul 3, 2024
View reviewed changes
Copy link
Collaborator

@bmhowe23 bmhowe23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@khalatepradnya khalatepradnya merged commit 27082f6 into NVIDIA:main Jul 3, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jul 3, 2024
@khalatepradnya khalatepradnya deleted the fix-issue-1218 branch July 3, 2024 17:18
@bettinaheim bettinaheim changed the title [Bug-fix] [Python] Address scoping issue for sample_async Address scoping issue for sample_async Jul 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@bmhowe23 bmhowe23 bmhowe23 approved these changes

@amccaskey amccaskey Awaiting requested review from amccaskey

@1tnguyen 1tnguyen Awaiting requested review from 1tnguyen

Assignees

@khalatepradnya khalatepradnya

Labels

bug fix To be listed under Bug Fixes in the release notes python-lang Anything related to the Python CUDA Quantum language implementation

Projects

None yet

Milestone

release 0.8.0

Development

Successfully merging this pull request may close these issues.

Out of scope kernel

2 participants

@khalatepradnya @bmhowe23