NVQC API versioning updates and advance REST API to v1.1 #1941
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
sacpis
reviewed
Jul 17, 2024
sacpis
reviewed
Jul 17, 2024
sacpis
reviewed
Jul 17, 2024
sacpis
approved these changes
Jul 17, 2024
|
Note: if #1958 is merged prior to this PR, then remove the vqe_h2.cpp exception that was added to the integration tests because this PR fixes that issue. |
bettinaheim
approved these changes
Jul 18, 2024
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
bettinaheim
added
the
release notes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the client and server API handling code to better handle advancing the capabilities of the server without having to update the client. The basic use case of this will be adding new features to the server while allowing users to keep using old client versions (if desired). As long as the server updates are done in a non-breaking way, we would simply advance the REST API version on the server from 1.0 to 1.1, 1.1 to 1.2, etc. If there is a breaking change on the server where old clients could not talk to the new server, we would advance the REST API version to 2.0.
For changes like the recent VQE and optimizer updates, the client can retrieve the server information in order to figure out whether the "new" way is available. If the "new" way is unavailable, then it will simply fall back on the slower (but still functional) old way.
Note: the
remote-mqputarget behaves as if the client and server are essentially at the same version. That is - the client assumes that the server has all the optional capabilities that the client knows about. It behaved like that before, and this PR does not change that.The 1st commit of this PR actually fixes a bug where the NVQC VQE updates from #1901 were not working correctly for the actual NVQC target. The 2nd and 3rd commits reduce some duplicated code in PyRemoteSimulatorQPU.cpp in order to make it less like that the oversight in #1901 happens again. I can pull all 3 of those commits into a separate PR if desired.