-
Notifications
You must be signed in to change notification settings - Fork 294
New Tutorial - Divisive Clustering #1990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
CLA Assistant Lite bot All Contributors have signed the CLA. |
Command Bot: Processing... |
|
I have read the Contributor License Agreement and I hereby accept the Terms. |
|
recheck |
Command Bot: Processing... |
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
|
@bmhowe23 , Thanks so much for this. I just saw the preview and it looks like the LaTeX in the notebooks does not render. And I also noticed the divisive clustering function now shows up a bullet point in the tutorial page, but clicking on it does not open anything so I think we would want that hidden. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current set of commits pass the CI, but the new notebook has to be skipped during the regular per-PR validation since it requires GPUs to execute. In fact, it requires the nvidia-mgpu backend to really run it will rarely get exercised by the CI if we were to merge this PR right now. We should probably discuss what the best path forward is. The options that I can think of are:
- Leave it as is right now and just know that the CI will not exercise the notebook on a regular basis
- Remove the
nvidia-mgpudependency to make it run during Deployment (but still not during the per-PR CI) - Remove all
nvidiatarget dependencies (somehow?) so that it runs with every PR.
Yeah, the LaTeX doesn't render in the GH docs preview for some reason...that's a known issue. The best way to review it is to run
That's strange, it works for me. Maybe we should sync up offline to make sure we're looking at the same thing. |
Command Bot: Processing... |
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
* Fix wget to write to specific subdirectory * Add mpi4py back to requirements list because it isn't in the devdeps image * Bump some package versions to be the same as other versions used by other notebooks in this same directory for consistency. * Fix a misspelling * Change python --> python3 for script invocations (for devdeps image) * Check the number of GPUs before attempting the nvidia-mgpu target
Command Bot: Processing... |
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
Command Bot: Processing... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Mark!
Description
I am uploading a new Jupyter notebook tutorial based on this https://arxiv.org/abs/2402.01529 paper focusing on divisive clustering. The tutorial was jointly developed with one of the authors. I placed the notebook in the docs section with all of the other notebooks. This example has a couple of auxiliary files, I created a source folder for them and use
wgetto grab the files if someone uses the notebook. If anything is placed in the wrong spot or needs to be modified, please let me know.