KEMBAR78
Quantum Filter diagonalization by marwafar · Pull Request #1997 · NVIDIA/cuda-quantum · GitHub
Skip to content

Quantum Filter diagonalization #1997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Aug 23, 2024
Merged

Quantum Filter diagonalization #1997

merged 20 commits into from
Aug 23, 2024

Conversation

@marwafar
Copy link
Collaborator

I added a new example to use quantum filter diagonalization to compute the ground state energy for molecules.

This example will highlight some new features we will have in cudaq 0.8

1- initialize qvector
2- pauli word
2- exp_pauli

@copy-pr-bot
Copy link

copy-pr-bot bot commented Jul 23, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@bmhowe23
Copy link
Collaborator

bmhowe23 commented Jul 23, 2024 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@bmhowe23
Copy link
Collaborator

bmhowe23 commented Jul 23, 2024 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@bmhowe23
Copy link
Collaborator

Thanks, @marwafar - this error in the CI means that you probably need to add a reference to the new tutorial in /workspaces/cuda-quantum/docs/sphinx/using/tutorials.rst.

/workspaces/cuda-quantum/docs/sphinx/examples/python/tutorials/LiH-MRQKS.ipynb: WARNING: document isn't included in any toctree

@marwafar
Copy link
Collaborator Author

tutorial.rst is updated

@bmhowe23
Copy link
Collaborator

bmhowe23 commented Jul 24, 2024 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Jul 24, 2024
@cuda-quantum-bot
Docs preview for PR #1997.
940650c
@bmhowe23 bmhowe23 added the documentation Improvements or additions to documentation label Jul 25, 2024
bmhowe23
bmhowe23 reviewed Jul 29, 2024
View reviewed changes
Copy link
Collaborator

@bmhowe23 bmhowe23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran this locally on my machine, and it took ~20 minutes on my machine with an RTX A6000. Since our Publishing CI job will try to run this on every commit to our repo, would it be possible to change this to H2 to reduce the runtime?

@bmhowe23
Copy link
Collaborator

bmhowe23 commented Aug 6, 2024 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@bmhowe23
Copy link
Collaborator

bmhowe23 commented Aug 6, 2024 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@github-actions
Copy link

github-actions bot commented Aug 6, 2024

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Aug 6, 2024
@cuda-quantum-bot
Docs preview for PR #1997.
ab42bc6
@bmhowe23
Copy link
Collaborator

bmhowe23 commented Aug 13, 2024 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Aug 13, 2024
@cuda-quantum-bot
Docs preview for PR #1997.
51438e7
@bmhowe23
Copy link
Collaborator

bmhowe23 commented Aug 23, 2024 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

github-actions bot pushed a commit that referenced this pull request Aug 23, 2024
@cuda-quantum-bot
Docs preview for PR #1997.
c0390df
@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

bmhowe23
bmhowe23 approved these changes Aug 23, 2024
View reviewed changes
Copy link
Collaborator

@bmhowe23 bmhowe23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Marwa.

@bmhowe23 bmhowe23 merged commit 99afd70 into NVIDIA:main Aug 23, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Aug 23, 2024
@bettinaheim bettinaheim added this to the release 0.9.0 milestone Nov 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@bmhowe23 bmhowe23 bmhowe23 approved these changes

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation

Projects

None yet

Milestone

release 0.9.0

Development

Successfully merging this pull request may close these issues.

3 participants

@marwafar @bmhowe23 @bettinaheim