KEMBAR78
CMake targets and other improvements for downstream projects by amccaskey · Pull Request #2014 · NVIDIA/cuda-quantum · GitHub
Skip to content

CMake targets and other improvements for downstream projects #2014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Aug 29, 2024
Merged

CMake targets and other improvements for downstream projects #2014

merged 11 commits into from
Aug 29, 2024

Conversation

@amccaskey
Copy link
Collaborator

@amccaskey amccaskey commented Jul 26, 2024 •
edited by bettinaheim
Loading

  • Create imported CMake targets for cudaq targets.
  • Enable downstream CMake to set the target.
  • Fix bug where fmtlib not found for downstream project import NVQIR config.
  • Fix issue printing out call error in python bridge.
  • Add serialize / deserialize to sample result in python bindings.
  • carry the custom operator name through to the GateApplicationTask.

See also #2144

@copy-pr-bot
Copy link

copy-pr-bot bot commented Jul 26, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

schweitzpgi
schweitzpgi reviewed Aug 2, 2024
View reviewed changes
Copy link
Collaborator

@schweitzpgi schweitzpgi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bmhowe23
bmhowe23 reviewed Aug 2, 2024
View reviewed changes
@amccaskey amccaskey force-pushed the updatesForDownstream branch from f58b94e to 61785c0 Compare August 26, 2024 16:47
@amccaskey amccaskey requested a review from bmhowe23 August 26, 2024 23:55
bmhowe23
bmhowe23 reviewed Aug 27, 2024
View reviewed changes
@bmhowe23
Copy link
Collaborator

bmhowe23 commented Aug 27, 2024 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

bmhowe23
bmhowe23 reviewed Aug 27, 2024
View reviewed changes
@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Aug 27, 2024
@cuda-quantum-bot
Docs preview for PR #2014.
061a442
@amccaskey amccaskey force-pushed the updatesForDownstream branch from 37ad2b7 to ce67ba3 Compare August 27, 2024 12:09
@amccaskey
Copy link
Collaborator Author

amccaskey commented Aug 27, 2024 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

bmhowe23
bmhowe23 approved these changes Aug 27, 2024
View reviewed changes
Copy link
Collaborator

@bmhowe23 bmhowe23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, Alex.

@amccaskey amccaskey enabled auto-merge (squash) August 27, 2024 13:45
amccaskey added 10 commits August 27, 2024 18:28
@amccaskey
fixes for cudaq-x
a28415b 
Signed-off-by: Alex McCaskey <amccaskey@nvidia.com>
@amccaskey
add targets to the cmake export
0f87779 
Signed-off-by: Alex McCaskey <amccaskey@nvidia.com>
@amccaskey
small fix for ast_bridge call op
f09aaae 
Signed-off-by: Alex McCaskey <amccaskey@nvidia.com>
@amccaskey
make sure to forward the name along
7028657 
Signed-off-by: Alex McCaskey <amccaskey@nvidia.com>
@amccaskey
don't default link builder to cudaq
98f1021 
Signed-off-by: Alex McCaskey <amccaskey@nvidia.com>
@amccaskey
fix fmt find
75ca13d 
Signed-off-by: Alex McCaskey <amccaskey@nvidia.com>
@amccaskey
minor cleanup
161034c 
Signed-off-by: Alex McCaskey <amccaskey@nvidia.com>
@amccaskey
address pr comments - fmt commit hash and default to qpp-cpu if NV gp…
1174911 
…us aren't available

Signed-off-by: Alex McCaskey <amccaskey@nvidia.com>
@amccaskey
address pr comments - prefer cusvsim targets if available
4e4d0dd 
Signed-off-by: Alex McCaskey <amccaskey@nvidia.com>
@amccaskey
Use nvidia-smi to see if we have gpus
23b0dde 
Signed-off-by: Alex McCaskey <amccaskey@nvidia.com>
@amccaskey amccaskey force-pushed the updatesForDownstream branch from ce67ba3 to 23b0dde Compare August 27, 2024 18:28
@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Aug 27, 2024
@cuda-quantum-bot
Docs preview for PR #2014.
c3492bb
@amccaskey
Copy link
Collaborator Author

amccaskey commented Aug 28, 2024 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Aug 28, 2024
@cuda-quantum-bot
Docs preview for PR #2014.
b901ef5
github-actions bot pushed a commit that referenced this pull request Aug 28, 2024
@cuda-quantum-bot
Docs preview for PR #2014.
97f84cd
@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

@amccaskey
Copy link
Collaborator Author

amccaskey commented Aug 29, 2024 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@amccaskey amccaskey merged commit 7f63804 into NVIDIA:main Aug 29, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Aug 29, 2024
@bettinaheim bettinaheim changed the title Minor updates for downstream projects. CMake targets and other improvements for downstream projects Nov 19, 2024
@bettinaheim bettinaheim added the release notes Changes need to be captured in the release notes label Nov 19, 2024
@bettinaheim bettinaheim added this to the release 0.9.0 milestone Nov 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@schweitzpgi schweitzpgi schweitzpgi left review comments

@bmhowe23 bmhowe23 bmhowe23 approved these changes

Assignees

No one assigned

Labels

release notes Changes need to be captured in the release notes

Projects

None yet

Milestone

release 0.9.0

Development

Successfully merging this pull request may close these issues.

4 participants

@amccaskey @bmhowe23 @schweitzpgi @bettinaheim