KEMBAR78
Add dynamic tuple layout handling by schweitzpgi · Pull Request #2109 · NVIDIA/cuda-quantum · GitHub
Skip to content

Conversation

@schweitzpgi
Copy link
Collaborator

@schweitzpgi schweitzpgi commented Aug 19, 2024

A std::tuple can be laid out in memory either like a struct or like the reverse of a struct. We need to be able to detect which one of these schemes is being used and it depends on the C++ headers being used. (libstdc++ is reversed, while libc++ is like a struct.)

A std::tuple can be laid out in memory either like a struct or like the
reverse of a struct. We need to be able to detect which one of these
schemes is being used and it depends on the C++ headers being used.
(libstdc++ is reversed, while libc++ is like a struct.)

Update tests.
@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Aug 20, 2024
@schweitzpgi schweitzpgi enabled auto-merge (squash) August 20, 2024 14:39
@schweitzpgi schweitzpgi requested a review from amccaskey August 20, 2024 14:39
github-actions bot pushed a commit that referenced this pull request Aug 20, 2024
@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

Copy link
Collaborator

@khalatepradnya khalatepradnya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks, Eric.

@schweitzpgi schweitzpgi merged commit 5d9a9e0 into NVIDIA:main Aug 20, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Aug 20, 2024
@schweitzpgi schweitzpgi deleted the ch-tuples branch August 20, 2024 22:03
@bettinaheim bettinaheim added the bug fix To be listed under Bug Fixes in the release notes label Nov 19, 2024
@bettinaheim bettinaheim added this to the release 0.9.0 milestone Nov 19, 2024
@bettinaheim bettinaheim changed the title [core] Add dynamic tuple layout handling. Add dynamic tuple layout handling Nov 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug fix To be listed under Bug Fixes in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants