Update regtomem to handle more cases #2135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The regtomem pass has pretty limited applicability. It can, under the correct preconditions, recover the quantum reference semantics model. However, it could fail in the presence of control-flow, so was only reliable when the kernel was a single block. This PR reimplements much of regtomem to make it work with control-flow and the CC dialect's IfOp. Add a test. The pass will no longer raise a fatal error if the input is in a form that shares quake operations ambiguously between multiple qubits. A note on borrow/return: running this pass on borrow/return will *not* preserve the semantics of that form. The map from the virtual reference domain to a borrow set is a surjective function. We make this a quasi-bijective function but re-resolving the scope of the borrow to be global. The extra qubits can be cleaned up by another pass.
schweitzpgi
force-pushed
the
ch-reg2mem
branch
from
b4ddfa2 to
0ab3eff
Compare
bmhowe23
reviewed
Aug 23, 2024
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
bmhowe23
approved these changes
Aug 23, 2024
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
bettinaheim
added
the
release notes
bettinaheim
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The regtomem pass has pretty limited applicability. It can, under the correct preconditions, recover the quantum reference semantics model. However, it could fail in the presence of control-flow, so was only reliable when the kernel was a single block.
This PR reimplements much of regtomem to make it work with control-flow and the CC dialect's IfOp.
Add a test. The pass will no longer raise a fatal error if the input is in a form that shares quake operations ambiguously between multiple qubits.
A note on borrow/return: running this pass on borrow/return will not preserve the semantics of that form. The map from the virtual reference domain to a borrow set is a surjective function. We make this a quasi-bijective function but re-resolving the scope of the borrow to be global. The extra qubits can be cleaned up by another pass.
See also #2189 for additional improvements.