Update decomposition patterns for value semantics #2145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update QuakeOperator builders to automatically return wires when appropriate * Create helpers to allow common "create" functions for both reference semantics and value semantics * Update UnitaryBuilder to understand unwraps
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
boschmitt
reviewed
Aug 26, 2024
schweitzpgi
reviewed
Aug 26, 2024
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
* Allows a mixture of reference semantics and value semantics in a single operation * Add mixed semantics test * Allows `quake.control` types where possible
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
schweitzpgi
approved these changes
Aug 28, 2024
bettinaheim
added
the
release notes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update QuakeOperator builders to automatically return wires when appropriate.(Edit: removed per an offline discussion that stated that unlike passes, where we want to have the passes support multiple IR flavors, it was preferred to have the builders only support reference semantics)Note: this does not do the
quake.exp_paulioperation because we cannot currently getquake.exp_paulioperations into value semantics form yet.