Updates to Shor's algorithm notebook #2178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added pip install command, fixed big-endian issues, added more comments for clarity
Command Bot: Processing... |
bmhowe23
reviewed
Aug 29, 2024
bmhowe23
reviewed
Aug 29, 2024
bmhowe23
reviewed
Aug 29, 2024
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
Co-authored-by: Ben Howe <141149032+bmhowe23@users.noreply.github.com>
Co-authored-by: Ben Howe <141149032+bmhowe23@users.noreply.github.com>
removed cell outputs from the pip install
should be good to go now
Command Bot: Processing... |
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
|
[celebrate] Monica Van Dieren reacted to your message:
…________________________________
From: Ben Howe ***@***.***>
Sent: Friday, August 30, 2024 5:53:42 PM
To: NVIDIA/cuda-quantum ***@***.***>
Cc: Monica Van Dieren ***@***.***>; Author ***@***.***>
Subject: Re: [NVIDIA/cuda-quantum] Shors edits (PR #2178)
@bmhowe23 approved this pull request.
This LGTM 👍
—
Reply to this email directly, view it on GitHub<#2178 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BDZBKEG4UEUESWZJYXD5CY3ZUCWSNAVCNFSM6AAAAABNLF2MSGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDENZTGE4TEMRYHE>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
removed all endian references. Double checked all the circuits so that the qubit order is correct for the operation intended.