KEMBAR78
One- and Two-qubit operation synthesis by khalatepradnya · Pull Request #2217 · NVIDIA/cuda-quantum · GitHub
Skip to content

One- and Two-qubit operation synthesis #2217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Oct 1, 2024
Merged

One- and Two-qubit operation synthesis #2217

merged 20 commits into from
Oct 1, 2024

Conversation

@khalatepradnya
Copy link
Collaborator

@khalatepradnya khalatepradnya commented Sep 19, 2024 •
edited by bettinaheim
Loading

Towards: #1475

Synthesize two-qubit custom operations using KAK decomposition
Single qubit operation synthesis: #2154

github-actions bot pushed a commit that referenced this pull request Sep 19, 2024
@cuda-quantum-bot
Docs preview for PR #2217.
1811165
@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

@khalatepradnya khalatepradnya self-assigned this Sep 19, 2024
@khalatepradnya khalatepradnya force-pushed the kak-decomp branch 2 times, most recently from ca7e132 to 4f1c808 Compare September 19, 2024 18:05
@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Sep 19, 2024
@cuda-quantum-bot
Docs preview for PR #2217.
aa91047
@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Sep 20, 2024
@cuda-quantum-bot
Docs preview for PR #2217.
bd8bf87
@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Sep 21, 2024
@cuda-quantum-bot
Docs preview for PR #2217.
3adcef5
@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Sep 21, 2024
@cuda-quantum-bot
Docs preview for PR #2217.
199d561
@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Sep 24, 2024
@cuda-quantum-bot
Docs preview for PR #2217.
b030037
github-actions bot pushed a commit that referenced this pull request Sep 25, 2024
@cuda-quantum-bot
Docs preview for PR #2217.
e8a7e86
@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

@khalatepradnya
* Added failing test(s)
ba0f21d 
* Skeleton for a new decomposer class
* Refactoring
* Saving progress
* Random Python tests
@khalatepradnya
* Saving progress
079fb2a
@khalatepradnya
* Using QZ decomposition
f662429
@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Sep 27, 2024
@cuda-quantum-bot
Docs preview for PR #2217.
2e5a379
github-actions bot pushed a commit that referenced this pull request Sep 28, 2024
@cuda-quantum-bot
Docs preview for PR #2217.
bc06a9a
@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

@khalatepradnya
* Refactor one-qubit decomposer to use eigen matrix
0f5c3ff 
* Increase tolerance to check for unitary
* Use CHECK-DAG in lit tests, also less precision for angles
@khalatepradnya
* Use 2.0 as the multiplicant
36ab23d
@khalatepradnya khalatepradnya marked this pull request as ready for review September 28, 2024 23:36
@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Sep 29, 2024
@cuda-quantum-bot
Docs preview for PR #2217.
96a4fe8
1tnguyen
1tnguyen reviewed Sep 29, 2024
View reviewed changes
1tnguyen
1tnguyen approved these changes Sep 30, 2024
View reviewed changes
Copy link
Collaborator

@1tnguyen 1tnguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

github-actions bot pushed a commit that referenced this pull request Sep 30, 2024
@cuda-quantum-bot
Docs preview for PR #2217.
fb30ca4
@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

@github-actions
Copy link

github-actions bot commented Oct 1, 2024

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Oct 1, 2024
@cuda-quantum-bot
Docs preview for PR #2217.
b47d324
sacpis
sacpis approved these changes Oct 1, 2024
View reviewed changes
Copy link
Collaborator

@sacpis sacpis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @khalatepradnya.

@github-actions
Copy link

github-actions bot commented Oct 1, 2024

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Oct 1, 2024
@cuda-quantum-bot
Docs preview for PR #2217.
81894a0
@khalatepradnya khalatepradnya merged commit 458c365 into NVIDIA:main Oct 1, 2024
129 checks passed
@khalatepradnya khalatepradnya deleted the kak-decomp branch October 1, 2024 17:00
@github-actions github-actions bot locked and limited conversation to collaborators Oct 1, 2024
@khalatepradnya khalatepradnya linked an issue Oct 1, 2024 that may be closed by this pull request
[RFC] Unitary Synthesis #1475
Open
12 tasks
@bettinaheim bettinaheim added this to the release 0.9.0 milestone Nov 19, 2024
@bettinaheim bettinaheim changed the title [custom op] Two-qubit operation synthesis One- and Two-qubit operation synthesis Nov 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sacpis sacpis sacpis approved these changes

@1tnguyen 1tnguyen 1tnguyen approved these changes

@boschmitt boschmitt Awaiting requested review from boschmitt

@annagrin annagrin Awaiting requested review from annagrin

@schweitzpgi schweitzpgi Awaiting requested review from schweitzpgi

Assignees

@khalatepradnya khalatepradnya

Labels

ecosystem enhancement New feature or request

Projects

None yet

Milestone

release 0.9.0

Development

Successfully merging this pull request may close these issues.

[RFC] Unitary Synthesis

4 participants

@khalatepradnya @sacpis @1tnguyen @bettinaheim