KEMBAR78
Generate coverage data when pusing to main by caiyunh · Pull Request #2442 · NVIDIA/cuda-quantum · GitHub
Skip to content

Generate coverage data when pusing to main #2442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Dec 10, 2024
Merged

Generate coverage data when pusing to main #2442

merged 7 commits into from
Dec 10, 2024

Conversation

@caiyunh
Copy link
Contributor

@caiyunh caiyunh commented Nov 29, 2024 •
edited by bettinaheim
Loading

Description

Background
This is about the unfinished work in the last step of PR diff coverage. We need to enable code coverage of the main branch so that the app can show diff on PR (link).

Note: Since this PR has not been tested on the CICD of this project, there may still be problems

Deployment workflow: https://github.com/NVIDIA/cuda-quantum/actions/runs/12263241490

generate coverage data when pusing to main
7ca4e80 
Signed-off-by: Iris Huang <caiyunh@caiyunh-mlt.client.nvidia.com>
@copy-pr-bot
Copy link

copy-pr-bot bot commented Nov 29, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@caiyunh caiyunh changed the title generate coverage data when pusing to main Generate coverage data when pusing to main Nov 30, 2024
@bettinaheim
create code coverage as part of deployment
1062cac 
Signed-off-by: Bettina Heim <heimb@outlook.com>
bettinaheim
bettinaheim reviewed Dec 10, 2024
View reviewed changes
Copy link
Collaborator

@bettinaheim bettinaheim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took the liberty of pushing an update that integrates this into the deployment workflow.
This means that code coverage will also be created for other branch protected branches, such as release and staging branches. Additionally, this avoids an additional rebuild of the dev dependencies.

@bettinaheim
Copy link
Collaborator

bettinaheim commented Dec 10, 2024 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@bettinaheim
Copy link
Collaborator

bettinaheim commented Dec 10, 2024 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

github-actions bot pushed a commit that referenced this pull request Dec 10, 2024
@cuda-quantum-bot
Docs preview for PR #2442.
d6bb09a
@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

@bettinaheim bettinaheim enabled auto-merge (squash) December 10, 2024 20:29
@bettinaheim bettinaheim merged commit 1e383a6 into NVIDIA:main Dec 10, 2024
437 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 10, 2024
@cuda-quantum-bot
Cleaning up docs preview for PR #2442.
6bb0027
bharat-thotakura pushed a commit to bharat-thotakura/cuda-quantum that referenced this pull request Dec 10, 2024
@caiyunh @bettinaheim @bharat-thotakura
Generate coverage data when pusing to main (NVIDIA#2442)
4f8cbd4 
Signed-off-by: Iris Huang <caiyunh@caiyunh-mlt.client.nvidia.com>
Signed-off-by: Bettina Heim <heimb@outlook.com>
Co-authored-by: Iris Huang <caiyunh@caiyunh-mlt.client.nvidia.com>
Co-authored-by: Bettina Heim <heimb@outlook.com>
@bettinaheim bettinaheim added the maintenance Work items to update and improve the code base label Dec 11, 2024
bettinaheim added a commit that referenced this pull request Dec 11, 2024
@caiyunh @bettinaheim
Generate coverage data when pusing to main (#2442)
aad46ca 
Signed-off-by: Iris Huang <caiyunh@caiyunh-mlt.client.nvidia.com>
Signed-off-by: Bettina Heim <heimb@outlook.com>
Co-authored-by: Iris Huang <caiyunh@caiyunh-mlt.client.nvidia.com>
Co-authored-by: Bettina Heim <heimb@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bettinaheim bettinaheim bettinaheim approved these changes

@1tnguyen 1tnguyen Awaiting requested review from 1tnguyen 1tnguyen is a code owner

@bmhowe23 bmhowe23 Awaiting requested review from bmhowe23 bmhowe23 is a code owner

Assignees

No one assigned

Labels

maintenance Work items to update and improve the code base

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@caiyunh @bettinaheim