KEMBAR78
Normalize loops with negative upper bounds by annagrin · Pull Request #2573 · NVIDIA/cuda-quantum · GitHub
Skip to content

Normalize loops with negative upper bounds #2573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 3, 2025
Merged

Normalize loops with negative upper bounds #2573

merged 1 commit into from
Feb 3, 2025

Conversation

@annagrin
Copy link
Collaborator

@annagrin annagrin commented Feb 2, 2025

Description

Normalize loops with negative upper boundaries

Example of a loop that was not previously normalized and subsequently not unrolled

%1 = cc.loop while ((%arg0 = %c0_i32) -> (i32)) {
%2 = arith.cmpi slt, %arg0, %c-1_i32 : i32
      cc.condition %2(%arg0 : i32)
} do {
...

Towards: #2458

@annagrin
Normalize loops with negative upper bounds
ad4c93f 
Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
@annagrin annagrin requested a review from schweitzpgi February 2, 2025 01:41
@annagrin annagrin mentioned this pull request Feb 2, 2025
Merged
@github-actions
Copy link

github-actions bot commented Feb 2, 2025

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Feb 2, 2025
@cuda-quantum-bot
Docs preview for PR #2573.
6556b00
@schweitzpgi
Copy link
Collaborator

The description is missing the step expression, which is a critical bit of information here.

schweitzpgi
schweitzpgi approved these changes Feb 3, 2025
View reviewed changes
Copy link
Collaborator

@schweitzpgi schweitzpgi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, Anna.

@annagrin annagrin merged commit 1ac1fab into NVIDIA:main Feb 3, 2025
213 checks passed
github-actions bot pushed a commit that referenced this pull request Feb 3, 2025
@cuda-quantum-bot
Cleaning up docs preview for PR #2573.
2b0c31b
@bettinaheim bettinaheim added the release notes Changes need to be captured in the release notes label Mar 12, 2025
@bettinaheim bettinaheim added this to the release 0.10.0 milestone Mar 12, 2025
annagrin added a commit to annagrin/cuda-quantum that referenced this pull request Jun 17, 2025
@annagrin
Normalize loops with negative upper bounds (NVIDIA#2573)
2f0ceee 
Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@schweitzpgi schweitzpgi schweitzpgi approved these changes

Assignees

No one assigned

Labels

release notes Changes need to be captured in the release notes

Projects

None yet

Milestone

release 0.10.0

Development

Successfully merging this pull request may close these issues.

3 participants

@annagrin @schweitzpgi @bettinaheim