KEMBAR78
Make synthesis transitive by annagrin · Pull Request #2644 · NVIDIA/cuda-quantum · GitHub
Skip to content

Make synthesis transitive #2644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Mar 12, 2025
Merged

Make synthesis transitive #2644

merged 16 commits into from
Mar 12, 2025

Conversation

@annagrin
Copy link
Collaborator

Description

Make synthesis transitive

Allow substitutions in subst modules:

func.func @testy5(%arg0: i32) -> i32 {
  return %arg0: i32
}

Substitutions:

testy5:

cc.arg_subst[0] {
  %0 = arith.constant 2 : i32
}
func.func private @callee5(%arg0: i32) -> (i32) {
  return %arg0: i32
}

callee5:

cc.arg_subst[0] {
  %c4_i64 = arith.constant 4 : i32
}

Result:

func.func @testy5() -> i32 {
  %c2_i32 = arith.constant 2 : i32
  return %c2_i32 : i32
}
func.func private @callee5() -> i32 {
  %c4_i32 = arith.constant 4 : i32
  return %c4_i32 : i32
}

@annagrin
Make argument synthesis transitive
a41bba7 
Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
@annagrin
Merge branch 'main' of https://github.com/NVIDIA/cuda-quantum into sy…
511dbe7 
…nthesis-substs

Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
@annagrin annagrin mentioned this pull request Feb 20, 2025
Merged
schweitzpgi
schweitzpgi reviewed Feb 20, 2025
View reviewed changes
@annagrin
Update callers of synthesis
7950a79 
Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
schweitzpgi
schweitzpgi reviewed Feb 20, 2025
View reviewed changes
schweitzpgi
schweitzpgi reviewed Feb 20, 2025
View reviewed changes
Copy link
Collaborator

@schweitzpgi schweitzpgi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for splitting this out.

@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Feb 20, 2025
@cuda-quantum-bot
Docs preview for PR #2644.
13532d2
annagrin added 2 commits March 3, 2025 10:03
@annagrin
Merge branch 'main' of https://github.com/NVIDIA/cuda-quantum into sy…
12c9421 
…nthesis-substs

Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
@annagrin
Make argument syntesis process functinos added from subst modules
8319add 
Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
schweitzpgi
schweitzpgi reviewed Mar 3, 2025
View reviewed changes
Copy link
Collaborator

@schweitzpgi schweitzpgi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. A couple of minor nits.

@github-actions
Copy link

github-actions bot commented Mar 3, 2025

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Mar 3, 2025
@cuda-quantum-bot
Docs preview for PR #2644.
019a9e3
annagrin and others added 3 commits March 3, 2025 14:04
@annagrin @schweitzpgi
Update test/Quake/arg_subst_func.qke
91e93ae 
Co-authored-by: Eric Schweitz <eschweitz@nvidia.com>
Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
@annagrin @schweitzpgi
Update lib/Optimizer/Transforms/ArgumentSynthesis.cpp
5749ce5 
Co-authored-by: Eric Schweitz <eschweitz@nvidia.com>
Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
@annagrin
Merge branch 'main' into synthesis-substs
6d77bb2
@annagrin annagrin enabled auto-merge (squash) March 3, 2025 22:05
@annagrin annagrin disabled auto-merge March 3, 2025 22:32
@annagrin
Fix failing build
52bc8cb 
Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
@github-actions
Copy link

github-actions bot commented Mar 4, 2025

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Mar 4, 2025
@cuda-quantum-bot
Docs preview for PR #2644.
136aa16
@github-actions
Copy link

github-actions bot commented Mar 5, 2025

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Mar 5, 2025
@cuda-quantum-bot
Docs preview for PR #2644.
a88b534
@github-actions
Copy link

github-actions bot commented Mar 5, 2025

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Mar 5, 2025
@cuda-quantum-bot
Docs preview for PR #2644.
57ed182
@annagrin
Merge branch 'main' of https://github.com/NVIDIA/cuda-quantum into sy…
092a036 
…nthesis-substs

Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
@annagrin
Merge branch 'synthesis-substs' of https://github.com/annagrin/cuda-q…
09665ab 
…uantum into synthesis-substs

Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
github-actions bot pushed a commit that referenced this pull request Mar 10, 2025
@cuda-quantum-bot
Docs preview for PR #2644.
690cfe2
@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

@annagrin annagrin enabled auto-merge (squash) March 11, 2025 18:05
@annagrin annagrin disabled auto-merge March 11, 2025 19:01
@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Mar 11, 2025
@cuda-quantum-bot
Docs preview for PR #2644.
bd549bf
github-actions bot pushed a commit that referenced this pull request Mar 12, 2025
@cuda-quantum-bot
Docs preview for PR #2644.
8fd2453
@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Mar 12, 2025
@cuda-quantum-bot
Docs preview for PR #2644.
2a1c4db
@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

@annagrin annagrin enabled auto-merge (squash) March 12, 2025 22:18
@annagrin annagrin mentioned this pull request Mar 12, 2025
Merged
@annagrin annagrin merged commit c929cd1 into NVIDIA:main Mar 12, 2025
195 checks passed
github-actions bot pushed a commit that referenced this pull request Mar 12, 2025
@cuda-quantum-bot
Cleaning up docs preview for PR #2644.
18d9a39
@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

@bettinaheim bettinaheim added the release notes Changes need to be captured in the release notes label May 5, 2025
@bettinaheim bettinaheim added this to the release 0.11.0 milestone May 5, 2025
annagrin added a commit to annagrin/cuda-quantum that referenced this pull request Jun 17, 2025
@annagrin @schweitzpgi
Make synthesis transitive (NVIDIA#2644)
9b42c5c 
* Make argument synthesis transitive

Signed-off-by: Anna Gringauze <agringauze@nvidia.com>

* Update callers of synthesis

Signed-off-by: Anna Gringauze <agringauze@nvidia.com>

* Make argument syntesis process functinos added from subst modules

Signed-off-by: Anna Gringauze <agringauze@nvidia.com>

* Update test/Quake/arg_subst_func.qke

Co-authored-by: Eric Schweitz <eschweitz@nvidia.com>
Signed-off-by: Anna Gringauze <agringauze@nvidia.com>

* Update lib/Optimizer/Transforms/ArgumentSynthesis.cpp

Co-authored-by: Eric Schweitz <eschweitz@nvidia.com>
Signed-off-by: Anna Gringauze <agringauze@nvidia.com>

* Fix failing build

Signed-off-by: Anna Gringauze <agringauze@nvidia.com>

---------

Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
Co-authored-by: Eric Schweitz <eschweitz@nvidia.com>
Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@schweitzpgi schweitzpgi schweitzpgi approved these changes

Assignees

No one assigned

Labels

release notes Changes need to be captured in the release notes

Projects

None yet

Milestone

release 0.11.0

Development

Successfully merging this pull request may close these issues.

3 participants

@annagrin @schweitzpgi @bettinaheim