Some fixes for complex numbers and vectors #2739
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
…mplex-constprop-fix Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
1 similar comment
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
schweitzpgi
reviewed
Mar 18, 2025
Co-authored-by: Eric Schweitz <eschweitz@nvidia.com> Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
schweitzpgi
approved these changes
Mar 19, 2025
…mplex-constprop-fix Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
…uda-quantum into complex-constprop-fix Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
annagrin
commented
Mar 20, 2025
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
1tnguyen
added a commit
that referenced
this pull request
Apr 2, 2025
* State synthesis for quantum devices (#2291) * DCO Remediation Commit for Ben Howe <bhowe@nvidia.com> I, Ben Howe <bhowe@nvidia.com>, hereby add my Signed-off-by to this commit: 86681ef Signed-off-by: Ben Howe <bhowe@nvidia.com> Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * State pointer synthesis for quantum hardware Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Merge with main Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Merge with main Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Fix test failure on anyon platform Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Make StateInitialization a funcOp pass Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Fix issues and tests for the rest of quantum architectures Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Fix failing quantinuum state prep tests Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Address CR comments Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Format Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Fix failing test Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Format Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Format Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Replaced getState intrinsic by cc.get_state op Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Remove print Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Remove getCudaqState references Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Minor updates Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Fix failing quake test Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Add a few state-related cc ops Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Fix test_argument_conversion Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Add printing in failing tests Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Add printing in failing tests Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Fix failing tests Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Add description for new algorithm for state syntesis Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Fix tests Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Make intermediate IR legal by separating allocs * DCO Remediation Commit for Anna Gringauze <agringauze@nvidia.com> I, Anna Gringauze <agringauze@nvidia.com>, hereby add my Signed-off-by to this commit: 9563371 Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Address some PR comments Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Address more CR comments Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Cleanup Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Address CR comments Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Address more CR comments Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Address more CR comments Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Store new functions in subst module and update synthesis Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Make argument synthesis transitive Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Update callers of synthesis Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Use PointerOf in quake defs Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Addressed more CR comments Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Recursive with caching Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * StateAggregatorWithArgumentConverter Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Make ArgumentConverter handle the state call tree Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Make argument converter handle kernels created from states Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Fix null alloc size and add tests Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Keep storing ops when generating numSubits func Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Cleanup Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Cleanup Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Cleanup Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Fix failing test Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Fix failing doc build Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Address CR comments Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Address more CR comments and add a test Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Address more CR comments Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Fix links Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Fix links Signed-off-by: Anna Gringauze <agringauze@nvidia.com> --------- Signed-off-by: Ben Howe <bhowe@nvidia.com> Signed-off-by: Anna Gringauze <agringauze@nvidia.com> Co-authored-by: Ben Howe <bhowe@nvidia.com> * Some fixes for complex numbers and vectors (#2739) * Some fixes for complex numbers and vectors Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Cleanup Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Cleanup Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Update lib/Optimizer/Dialect/CC/CCOps.cpp Co-authored-by: Eric Schweitz <eschweitz@nvidia.com> Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Fix links Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Fix links Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Fix links Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Fix links Signed-off-by: Anna Gringauze <agringauze@nvidia.com> --------- Signed-off-by: Anna Gringauze <agringauze@nvidia.com> Co-authored-by: Eric Schweitz <eschweitz@nvidia.com> * Add docs for `apply_noise` (#2745) * Enabling afqmc notebook by freezing numba to 0.60.0 (#2759) * Enabling afqmc by freezing numba to 0.60.0 Signed-off-by: Sachin Pisal <spisal@nvidia.com> * removing afqmc form skipped_notebooks Signed-off-by: Sachin Pisal <spisal@nvidia.com> --------- Signed-off-by: Sachin Pisal <spisal@nvidia.com> * Replacing existing spin_ops with the general operators (#2710) This PR contains the full replacement of the existing spin_ops with the new general operators. See the PR description on GitHub for a full list of all changes. --------- Signed-off-by: Bettina Heim <heimb@outlook.com> Signed-off-by: Ben Howe <bhowe@nvidia.com> Signed-off-by: Anna Gringauze <agringauze@nvidia.com> Co-authored-by: Ben Howe <bhowe@nvidia.com> Co-authored-by: cuda-quantum-bot <cuda-quantum-bot@users.noreply.github.com> Co-authored-by: Anna Gringauze <agringauze@nvidia.com> * Allow Return Value Optimization instead of forcing moves (#2765) Signed-off-by: Ben Howe <bhowe@nvidia.com> * Dev Container psi-header extension: retain original copyright year (#2766) For those of us using VSCode dev containers, this makes the psi-header extension work with other projects that don't all have 2022 as a starting point. More specifically - with this change, the extension will attempt to retain the existing starting copyright year and update only the ending copyright year if it exists (rather than updating both the start copyright year and current copyright year). Additionally, if the file is a new file, it will use "now" as the starting copyright year, which is more correct anyway. Signed-off-by: Ben Howe <bhowe@nvidia.com> --------- Signed-off-by: Ben Howe <bhowe@nvidia.com> Signed-off-by: Anna Gringauze <agringauze@nvidia.com> Signed-off-by: Sachin Pisal <spisal@nvidia.com> Signed-off-by: Bettina Heim <heimb@outlook.com> Co-authored-by: Anna Gringauze <agringauze@nvidia.com> Co-authored-by: Ben Howe <bhowe@nvidia.com> Co-authored-by: Eric Schweitz <eschweitz@nvidia.com> Co-authored-by: Ben Howe <141149032+bmhowe23@users.noreply.github.com> Co-authored-by: Sachin Pisal <spisal@nvidia.com> Co-authored-by: Bettina Heim <heimb@outlook.com> Co-authored-by: cuda-quantum-bot <cuda-quantum-bot@users.noreply.github.com>
annagrin
added a commit
to annagrin/cuda-quantum
that referenced
this pull request
Jun 17, 2025
* State synthesis for quantum devices (NVIDIA#2291) * DCO Remediation Commit for Ben Howe <bhowe@nvidia.com> I, Ben Howe <bhowe@nvidia.com>, hereby add my Signed-off-by to this commit: 86681ef Signed-off-by: Ben Howe <bhowe@nvidia.com> Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * State pointer synthesis for quantum hardware Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Merge with main Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Merge with main Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Fix test failure on anyon platform Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Make StateInitialization a funcOp pass Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Fix issues and tests for the rest of quantum architectures Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Fix failing quantinuum state prep tests Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Address CR comments Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Format Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Fix failing test Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Format Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Format Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Replaced getState intrinsic by cc.get_state op Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Remove print Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Remove getCudaqState references Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Minor updates Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Fix failing quake test Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Add a few state-related cc ops Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Fix test_argument_conversion Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Add printing in failing tests Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Add printing in failing tests Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Fix failing tests Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Add description for new algorithm for state syntesis Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Fix tests Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Make intermediate IR legal by separating allocs * DCO Remediation Commit for Anna Gringauze <agringauze@nvidia.com> I, Anna Gringauze <agringauze@nvidia.com>, hereby add my Signed-off-by to this commit: 9563371 Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Address some PR comments Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Address more CR comments Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Cleanup Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Address CR comments Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Address more CR comments Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Address more CR comments Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Store new functions in subst module and update synthesis Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Make argument synthesis transitive Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Update callers of synthesis Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Use PointerOf in quake defs Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Addressed more CR comments Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Recursive with caching Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * StateAggregatorWithArgumentConverter Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Make ArgumentConverter handle the state call tree Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Make argument converter handle kernels created from states Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Fix null alloc size and add tests Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Keep storing ops when generating numSubits func Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Cleanup Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Cleanup Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Cleanup Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Fix failing test Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Fix failing doc build Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Address CR comments Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Address more CR comments and add a test Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Address more CR comments Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Fix links Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Fix links Signed-off-by: Anna Gringauze <agringauze@nvidia.com> --------- Signed-off-by: Ben Howe <bhowe@nvidia.com> Signed-off-by: Anna Gringauze <agringauze@nvidia.com> Co-authored-by: Ben Howe <bhowe@nvidia.com> * Some fixes for complex numbers and vectors (NVIDIA#2739) * Some fixes for complex numbers and vectors Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Cleanup Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Cleanup Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Update lib/Optimizer/Dialect/CC/CCOps.cpp Co-authored-by: Eric Schweitz <eschweitz@nvidia.com> Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Fix links Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Fix links Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Fix links Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Fix links Signed-off-by: Anna Gringauze <agringauze@nvidia.com> --------- Signed-off-by: Anna Gringauze <agringauze@nvidia.com> Co-authored-by: Eric Schweitz <eschweitz@nvidia.com> * Add docs for `apply_noise` (NVIDIA#2745) * Enabling afqmc notebook by freezing numba to 0.60.0 (NVIDIA#2759) * Enabling afqmc by freezing numba to 0.60.0 Signed-off-by: Sachin Pisal <spisal@nvidia.com> * removing afqmc form skipped_notebooks Signed-off-by: Sachin Pisal <spisal@nvidia.com> --------- Signed-off-by: Sachin Pisal <spisal@nvidia.com> * Replacing existing spin_ops with the general operators (NVIDIA#2710) This PR contains the full replacement of the existing spin_ops with the new general operators. See the PR description on GitHub for a full list of all changes. --------- Signed-off-by: Bettina Heim <heimb@outlook.com> Signed-off-by: Ben Howe <bhowe@nvidia.com> Signed-off-by: Anna Gringauze <agringauze@nvidia.com> Co-authored-by: Ben Howe <bhowe@nvidia.com> Co-authored-by: cuda-quantum-bot <cuda-quantum-bot@users.noreply.github.com> Co-authored-by: Anna Gringauze <agringauze@nvidia.com> * Allow Return Value Optimization instead of forcing moves (NVIDIA#2765) Signed-off-by: Ben Howe <bhowe@nvidia.com> * Dev Container psi-header extension: retain original copyright year (NVIDIA#2766) For those of us using VSCode dev containers, this makes the psi-header extension work with other projects that don't all have 2022 as a starting point. More specifically - with this change, the extension will attempt to retain the existing starting copyright year and update only the ending copyright year if it exists (rather than updating both the start copyright year and current copyright year). Additionally, if the file is a new file, it will use "now" as the starting copyright year, which is more correct anyway. Signed-off-by: Ben Howe <bhowe@nvidia.com> --------- Signed-off-by: Ben Howe <bhowe@nvidia.com> Signed-off-by: Anna Gringauze <agringauze@nvidia.com> Signed-off-by: Sachin Pisal <spisal@nvidia.com> Signed-off-by: Bettina Heim <heimb@outlook.com> Co-authored-by: Anna Gringauze <agringauze@nvidia.com> Co-authored-by: Ben Howe <bhowe@nvidia.com> Co-authored-by: Eric Schweitz <eschweitz@nvidia.com> Co-authored-by: Ben Howe <141149032+bmhowe23@users.noreply.github.com> Co-authored-by: Sachin Pisal <spisal@nvidia.com> Co-authored-by: Bettina Heim <heimb@outlook.com> Co-authored-by: cuda-quantum-bot <cuda-quantum-bot@users.noreply.github.com> Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
annagrin
added a commit
to annagrin/cuda-quantum
that referenced
this pull request
Jun 17, 2025
* Some fixes for complex numbers and vectors Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Cleanup Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Cleanup Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Update lib/Optimizer/Dialect/CC/CCOps.cpp Co-authored-by: Eric Schweitz <eschweitz@nvidia.com> Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Fix links Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Fix links Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Fix links Signed-off-by: Anna Gringauze <agringauze@nvidia.com> * Fix links Signed-off-by: Anna Gringauze <agringauze@nvidia.com> --------- Signed-off-by: Anna Gringauze <agringauze@nvidia.com> Co-authored-by: Eric Schweitz <eschweitz@nvidia.com> Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some fixes for complex numbers and vectors of complex numbers
(QuakeSynthesis, LiftArrayAlloc, ArgumentSynthesis, ConvertToQIR/eraseConstantArrayOps, etc)
complex<T>::real()andcomplex<T>::imag()in kernels in c++ (already supported in python)The fixes are inspired by a trotter example, where we would like to pass a vector of complex numbers to a kernel, be able to get a real part of it, and make sure it works for quantum devices.