CPP examples #2790
CPP examples #2790
Conversation
sacpis
requested review from
1tnguyen,
bettinaheim,
bmhowe23 and
schweitzpgi
as code owners
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
There was a problem hiding this comment.
There are a bunch of non-words being added to the English dictionary file. We shouldn't be spelling checking code, URLs, writing acronyms in all lower case, etc. The fixes for these should be in the comments or files that are being spell checked and not adding the residuals to the dictionary.
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
|
Thank you @schweitzpgi. Have removed those words from the allowed_list. |
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
…device_id Signed-off-by: Sachin Pisal <spisal@nvidia.com>
Signed-off-by: Sachin Pisal <spisal@nvidia.com>
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
1 similar comment
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
Signed-off-by: Sachin Pisal <spisal@nvidia.com>
Signed-off-by: Sachin Pisal <spisal@nvidia.com>
Signed-off-by: Sachin Pisal <spisal@nvidia.com>
Signed-off-by: Sachin Pisal <spisal@nvidia.com>
Signed-off-by: Sachin Pisal <spisal@nvidia.com>
…into cpp_examples
Signed-off-by: Sachin Pisal <spisal@nvidia.com>
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
| Measuring Kernels <measuring_kernels.rst> | ||
| Visualizing Kernels <../../examples/python/visualization.ipynb> | ||
| Executing Kernels <../../examples/python/executing_kernels.ipynb> | ||
| Executing Kernels <executing_kernels.rst> |
There was a problem hiding this comment.
@sacpis : Can you confirm that this was intentional?
It has overridden changes to https://github.com/NVIDIA/cuda-quantum/blob/main/docs/sphinx/examples/python/executing_kernels.ipynb from PR #3182
There was a problem hiding this comment.
Hey @khalatepradnya , Yes it was intentional as the requirement was to provide examples (of executing_kernels) for both Python and CPP. When I worked on it last year, the application team wanted all examples to be of Python notebook type. So I had to convert executing_kernels.ipynb to executing_kernels.py at the time.
Wouldn't the above change only display python notebook in a tab? Would you please try to generate documentation locally?
Please let me know if you have any questions.
There was a problem hiding this comment.
Got it, thanks!
See - #3268
* Adding pauli_x_gate cpp snippet Signed-off-by: Sachin Pisal <spisal@nvidia.com> * Fixing comments for pauli_x_gate Signed-off-by: Sachin Pisal <spisal@nvidia.com> * Adding hadamard gate cpp example Signed-off-by: Sachin Pisal <spisal@nvidia.com> * Adding cnot_gate cpp example Signed-off-by: Sachin Pisal <spisal@nvidia.com> * Formatting Signed-off-by: Sachin Pisal <spisal@nvidia.com> * Adding measuring_kernels example snippets Signed-off-by: Sachin Pisal <spisal@nvidia.com> * Adding executing_kernels for Python Signed-off-by: Sachin Pisal <spisal@nvidia.com> * Updating executing_kernels with cpp tab Signed-off-by: Sachin Pisal <spisal@nvidia.com> * Adding operators cpp examples Signed-off-by: Sachin Pisal <spisal@nvidia.com> * sorting and formatting Signed-off-by: Sachin Pisal <spisal@nvidia.com> * Fixing spelling Signed-off-by: Sachin Pisal <spisal@nvidia.com> * Adding building kernel examples Signed-off-by: Sachin Pisal <spisal@nvidia.com> * Formatting Signed-off-by: Sachin Pisal <spisal@nvidia.com> * Formatting, removing multi control synthesis Signed-off-by: Sachin Pisal <spisal@nvidia.com> * Removing spellings Signed-off-by: Sachin Pisal <spisal@nvidia.com> * Making parallization techniques part of executing kernels Signed-off-by: Sachin Pisal <spisal@nvidia.com> * Cleaning up multi_controlled_operations Signed-off-by: Sachin Pisal <spisal@nvidia.com> * fixing broken link Signed-off-by: Sachin Pisal <spisal@nvidia.com> * Fixing redifinition of kernel Signed-off-by: Sachin Pisal <spisal@nvidia.com> * Fixing cudaq::complex type and specifying type specifier Signed-off-by: Sachin Pisal <spisal@nvidia.com> * Formatting Signed-off-by: Sachin Pisal <spisal@nvidia.com> * minor fixes Signed-off-by: Sachin Pisal <spisal@nvidia.com> * uncomment the qubit kernel Signed-off-by: Sachin Pisal <spisal@nvidia.com> * formatting Signed-off-by: Sachin Pisal <spisal@nvidia.com> * Removing print statements Signed-off-by: Sachin Pisal <spisal@nvidia.com> * fix for measure Signed-off-by: Sachin Pisal <spisal@nvidia.com> * Fixing operators Signed-off-by: Sachin Pisal <spisal@nvidia.com> * fixing vector values Signed-off-by: Sachin Pisal <spisal@nvidia.com> * Adding a new kernel Signed-off-by: Sachin Pisal <spisal@nvidia.com> * Removing passing vector as a paramter to qubit due to a bug in python bridge Signed-off-by: Sachin Pisal <spisal@nvidia.com> * Excluding executing_kernels.cpp Signed-off-by: Sachin Pisal <spisal@nvidia.com> * correcting exclusion criteria Signed-off-by: Sachin Pisal <spisal@nvidia.com> * fixing spelling Signed-off-by: Sachin Pisal <spisal@nvidia.com> * Update docs/sphinx/using/examples/operators.rst Co-authored-by: Thien Nguyen <58006629+1tnguyen@users.noreply.github.com> Signed-off-by: Sachin Pisal <spisal@nvidia.com> * Update docs/sphinx/using/examples/measuring_kernels.rst Co-authored-by: Thien Nguyen <58006629+1tnguyen@users.noreply.github.com> Signed-off-by: Sachin Pisal <spisal@nvidia.com> * fix for measure kernel Signed-off-by: Sachin Pisal <spisal@nvidia.com> * implementing feedback received Signed-off-by: Sachin Pisal <spisal@nvidia.com> * Fixing parameters Signed-off-by: Sachin Pisal <spisal@nvidia.com> * Excluding executing_kernels test in absence of a remote server process Signed-off-by: Sachin Pisal <spisal@nvidia.com> * fixing bracket Signed-off-by: Sachin Pisal <spisal@nvidia.com> * Adding missing bracket Signed-off-by: Sachin Pisal <spisal@nvidia.com> * removing executing_kernels from the skip list Signed-off-by: Sachin Pisal <spisal@nvidia.com> * Adding descriptive message for debugging Signed-off-by: Sachin Pisal <spisal@nvidia.com> * Check for device_id only if there are non-zero qpus available Signed-off-by: Sachin Pisal <spisal@nvidia.com> * num of qpus should be greater than 0 in order to compare it with the device_id Signed-off-by: Sachin Pisal <spisal@nvidia.com> * checking nums of qpus directly with the device id Signed-off-by: Sachin Pisal <spisal@nvidia.com> * separating cpp examples Signed-off-by: Sachin Pisal <spisal@nvidia.com> * formatting Signed-off-by: Sachin Pisal <spisal@nvidia.com> * escaping words Signed-off-by: Sachin Pisal <spisal@nvidia.com> * escape words Signed-off-by: Sachin Pisal <spisal@nvidia.com> * Setting precision in output format Signed-off-by: Sachin Pisal <spisal@nvidia.com> * formatting Signed-off-by: Sachin Pisal <spisal@nvidia.com> --------- Signed-off-by: Sachin Pisal <spisal@nvidia.com> Co-authored-by: Thien Nguyen <58006629+1tnguyen@users.noreply.github.com>
5 participants
Adding cpp examples for the corresponding Python examples in CUDA-Q documentation.