KEMBAR78
Support for Quantum Machines backends by HanaGiatQM · Pull Request #2838 · NVIDIA/cuda-quantum · GitHub
Skip to content

Conversation

@HanaGiatQM
Copy link
Contributor

Description

@copy-pr-bot
Copy link

copy-pr-bot bot commented Apr 24, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@sacpis
Copy link
Collaborator

sacpis commented Apr 24, 2025

/ok to test a971aeb

Command Bot: Processing...

Signed-off-by: Sachin Pisal <spisal@nvidia.com>
@sacpis
Copy link
Collaborator

sacpis commented Apr 24, 2025

/ok to test 661a6de

Command Bot: Processing...

Signed-off-by: Sachin Pisal <spisal@nvidia.com>
@sacpis
Copy link
Collaborator

sacpis commented Apr 24, 2025

/ok to test 1b01897

Command Bot: Processing...

github-actions bot pushed a commit that referenced this pull request Apr 24, 2025
@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

Signed-off-by: Sachin Pisal <spisal@nvidia.com>
@sacpis
Copy link
Collaborator

sacpis commented Apr 24, 2025

/ok to test b8e96cc

Command Bot: Processing...

github-actions bot pushed a commit that referenced this pull request Apr 24, 2025
@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

Copy link
Collaborator

@khalatepradnya khalatepradnya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting this started! :)
Preliminary review.

HanaGiatQM and others added 3 commits May 6, 2025 10:23
# Conflicts:
#	docs/sphinx/targets/python/quantum_machines_3_qubit_ghz.py
#	runtime/cudaq/platform/default/rest/helpers/quantum_machines/QuantumMachinesServerHelper.cpp
#	utils/mock_qpu/quantum_machines/__init__.py
@sacpis
Copy link
Collaborator

sacpis commented May 6, 2025

/ok to test ea00eb9

Command Bot: Processing...

@github-actions
Copy link

github-actions bot commented May 6, 2025

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request May 6, 2025
@khalatepradnya
Copy link
Collaborator

For C++ formatting, run bash scripts/run_clang_format.sh .
For Python formatting, run yapf --style google -i <file_name>.py

@bmhowe23
Copy link
Collaborator

For C++ formatting, run bash scripts/run_clang_format.sh . For Python formatting, run yapf --style google -i <file_name>.py

Just FYI to save some keystrokes if you want, the --style google part shouldn't be required anymore since we added the .style.yapf file to the top level of the repo, though it does no harm in adding it.

@github-actions
Copy link

github-actions bot commented Jun 4, 2025

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

Signed-off-by: hanag <hana.giat@quantum-machines.co>
Signed-off-by: hanag <hana.giat@quantum-machines.co>
Signed-off-by: hanag <hana.giat@quantum-machines.co>
Signed-off-by: hanag <hana.giat@quantum-machines.co>
Copy link
Contributor

@nvidia-dobri nvidia-dobri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Minor comments. Let's just make sure CI passes.

@nvidia-dobri
Copy link
Contributor

nvidia-dobri commented Jun 18, 2025

/ok to test 307bdc0

Command Bot: Processing...

github-actions bot pushed a commit that referenced this pull request Jun 18, 2025
@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

@khalatepradnya
Copy link
Collaborator

khalatepradnya commented Jun 26, 2025

/ok to test 450ef0e

Command Bot: Processing...

github-actions bot pushed a commit that referenced this pull request Jun 26, 2025
@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

Copy link
Collaborator

@schweitzpgi schweitzpgi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving change to protected file.

Signed-off-by: hanag <hana.giat@quantum-machines.co>
@nvidia-dobri
Copy link
Contributor

nvidia-dobri commented Jul 1, 2025

/ok to test b4d5322

Command Bot: Processing...

Signed-off-by: Dobri Y <dyordanov@nvidia.com>
Signed-off-by: Dobri Y <dyordanov@nvidia.com>
@nvidia-dobri
Copy link
Contributor

nvidia-dobri commented Jul 1, 2025

/ok to test 6cf7f22

Command Bot: Processing...

@nvidia-dobri nvidia-dobri enabled auto-merge (squash) July 1, 2025 12:06
@nvidia-dobri nvidia-dobri merged commit 24dc929 into NVIDIA:main Jul 1, 2025
292 of 334 checks passed
github-actions bot pushed a commit that referenced this pull request Jul 1, 2025
@bettinaheim bettinaheim added the enhancement New feature or request label Jul 22, 2025
@bettinaheim bettinaheim added this to the release 0.12.0 milestone Jul 22, 2025
@bettinaheim bettinaheim changed the title Quantum Machines Server Helper Support for Quantum Machines backends Jul 22, 2025
atgeller pushed a commit to atgeller/cuda-quantum that referenced this pull request Jul 31, 2025
* Initial commit of QM template and a minimal test

* Initial commit of QM template and a minimal test

* Initial commit of QM template and a minimal test

* formatting

Signed-off-by: Sachin Pisal <spisal@nvidia.com>

* formatting

Signed-off-by: Sachin Pisal <spisal@nvidia.com>

* fixing import

Signed-off-by: Sachin Pisal <spisal@nvidia.com>

* Full QM ServerHelper and python examples

* Full QM ServerHelper and python examples

* Full QM ServerHelper and python examples - PR fixes

* ServerHelper PR fixes

* ServerHelper PR fixes - fix comment in sample

* ServerHelper PR fixes - fix comment in sample

* ServerHelper PR fixes - remove TODOs

* Gate decomposition and additional tests

* Add qubit mapping config option

* DCO Remediation Commit for hanag <hana.giat@quantum-machines.co>

I, hanag <hana.giat@quantum-machines.co>, hereby add my Signed-off-by to this commit: b596b0d
I, hanag <hana.giat@quantum-machines.co>, hereby add my Signed-off-by to this commit: 3497973
I, hanag <hana.giat@quantum-machines.co>, hereby add my Signed-off-by to this commit: d9abcf7
I, hanag <hana.giat@quantum-machines.co>, hereby add my Signed-off-by to this commit: 909cb80
I, hanag <hana.giat@quantum-machines.co>, hereby add my Signed-off-by to this commit: 809b718
I, hanag <hana.giat@quantum-machines.co>, hereby add my Signed-off-by to this commit: 9a8e82e
I, hanag <hana.giat@quantum-machines.co>, hereby add my Signed-off-by to this commit: 0e153e8
I, hanag <hana.giat@quantum-machines.co>, hereby add my Signed-off-by to this commit: d43e88c
I, hanag <hana.giat@quantum-machines.co>, hereby add my Signed-off-by to this commit: a96cf6e
I, hanag <hana.giat@quantum-machines.co>, hereby add my Signed-off-by to this commit: b66e653
I, hanag <hana.giat@quantum-machines.co>, hereby add my Signed-off-by to this commit: 50ba68c
I, hanag <hana.giat@quantum-machines.co>, hereby add my Signed-off-by to this commit: fb884a5

Signed-off-by: hanag <hana.giat@quantum-machines.co>

* Fix test server
Signed-off-by: hanag <hana.giat@quantum-machines.co>

* * Code formatting

Signed-off-by: Pradnya Khalate <pkhalate@nvidia.com>

* * Make spell checker happy.
* Python formatting.

Signed-off-by: Pradnya Khalate <pkhalate@nvidia.com>

* * Add a CMake build flag to make `quantum_machines` target opt-in.
* Enable a handful of representative target tests in emulation.

Signed-off-by: Pradnya Khalate <pkhalate@nvidia.com>

* * Enabling Python test with mock server

Signed-off-by: Pradnya Khalate <pkhalate@nvidia.com>

* Move api key to getHeaders
Signed-off-by: hanag <hana.giat@quantum-machines.co>

* Fix tests, remove some decomposition patterns
Signed-off-by: hanag <hana.giat@quantum-machines.co>

* Remove qubit_mapping option and add gates test
Signed-off-by: hanag <hana.giat@quantum-machines.co>

* PR comments
Signed-off-by: hanag <hana.giat@quantum-machines.co>

* Fix formatting by clang-format -i
Signed-off-by: hanag <hana.giat@quantum-machines.co>

* Fix CI

Signed-off-by: Dobri Y <dyordanov@nvidia.com>

* Fix headers

Signed-off-by: Dobri Y <dyordanov@nvidia.com>

---------

Signed-off-by: Sachin Pisal <spisal@nvidia.com>
Signed-off-by: hanag <hana.giat@quantum-machines.co>
Signed-off-by: Pradnya Khalate <pkhalate@nvidia.com>
Signed-off-by: Dobri Y <dyordanov@nvidia.com>
Co-authored-by: Sachin Pisal <spisal@nvidia.com>
Co-authored-by: Pradnya Khalate <148914294+khalatepradnya@users.noreply.github.com>
Co-authored-by: Pradnya Khalate <pkhalate@nvidia.com>
Co-authored-by: Dobri Yordanov <dyordanov@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants