KEMBAR78
Support input state batching in dynamics `evolve` by 1tnguyen · Pull Request #2921 · NVIDIA/cuda-quantum · GitHub
Skip to content

Conversation

@1tnguyen
Copy link
Collaborator

@1tnguyen 1tnguyen commented May 16, 2025

Description

Aggregate input states into a batch for more efficient cudensitymat simulation.

Note: We already had this API (list of states as initial states). Previously, we ran them sequentially. Now, we combine them into a batched state.

@1tnguyen 1tnguyen force-pushed the tnguyen/dynamics-state-batching branch 2 times, most recently from fa82c21 to e3fe6e7 Compare May 16, 2025 04:12
github-actions bot pushed a commit that referenced this pull request May 16, 2025
@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

@1tnguyen 1tnguyen force-pushed the tnguyen/dynamics-state-batching branch from e3fe6e7 to 9b51bea Compare May 16, 2025 04:46
github-actions bot pushed a commit that referenced this pull request May 16, 2025
@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

@1tnguyen 1tnguyen force-pushed the tnguyen/dynamics-state-batching branch 2 times, most recently from 07a65d4 to 0914680 Compare May 19, 2025 05:28
github-actions bot pushed a commit that referenced this pull request May 19, 2025
@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com>

Work on batched state

Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com>

Split the batched state for return

Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com>

Proper callback support

Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com>

[WIP] Temp code supporting batching in Python

Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com>

Fix after rebase

Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com>

Support batch

Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com>

Code cleanup

Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com>

Code format

Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com>

Code format

Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com>

add example

Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com>

Fix spelling

Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com>
@1tnguyen 1tnguyen force-pushed the tnguyen/dynamics-state-batching branch from 0914680 to d2c92af Compare May 21, 2025 04:52
@1tnguyen 1tnguyen marked this pull request as ready for review May 21, 2025 04:55
github-actions bot pushed a commit that referenced this pull request May 21, 2025
@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request May 22, 2025
@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

1tnguyen added 2 commits May 26, 2025 01:54
Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com>
Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com>
github-actions bot pushed a commit that referenced this pull request May 26, 2025
@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

Copy link
Collaborator

@sacpis sacpis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments but overall it looks good to me. Thanks @1tnguyen.

Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com>
github-actions bot pushed a commit that referenced this pull request May 27, 2025
@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

@1tnguyen 1tnguyen merged commit 1d62d8d into NVIDIA:main May 27, 2025
197 checks passed
github-actions bot pushed a commit that referenced this pull request May 27, 2025
annagrin pushed a commit to annagrin/cuda-quantum that referenced this pull request Jun 17, 2025
* [WIP] input state batching

Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com>

Work on batched state

Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com>

Split the batched state for return

Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com>

Proper callback support

Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com>

[WIP] Temp code supporting batching in Python

Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com>

Fix after rebase

Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com>

Support batch

Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com>

Code cleanup

Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com>

Code format

Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com>

Code format

Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com>

add example

Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com>

Fix spelling

Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com>

* Code format for python tests

Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com>

* Fix a merge issue

Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com>

* Code review: address comments

Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com>

---------

Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com>
Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
@bettinaheim bettinaheim added the enhancement New feature or request label Jul 22, 2025
@bettinaheim bettinaheim added this to the release 0.12.0 milestone Jul 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants