Proper handling of evolve_async input state
#2951
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need to migrate the input state to proper QPU for execution. Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com>
sacpis
approved these changes
May 23, 2025
|
A question. Do we cover this case in tests for evolve_async? |
Yes. In fact, it's how I detected this bug :) It came to light thanks to the refactor we did in The |
|
Thanks @1tnguyen. |
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
annagrin
pushed a commit
to annagrin/cuda-quantum
that referenced
this pull request
Jun 17, 2025
Need to migrate the input state to proper QPU for execution. Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com> Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The input state to
evolve_asyncmay be constructed on a different device (GPU), as this state is built on the main thread before the async. functor is executed.Hence, adding a helper function to detect and migrate the state data if needed.