Add support for some math functions inside kernels #2989
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of the math functions on the list only appear in MLIR after LLVM 16. However, we can add support for the rest to the C++ bridge. This patch adds support for sin, cos, tan, exp, log, ceil, and floor. Signed-off-by: Eric Schweitz <eschweitz@nvidia.com>
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
sacpis
approved these changes
Jun 4, 2025
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
annagrin
pushed a commit
to annagrin/cuda-quantum
that referenced
this pull request
Jun 17, 2025
…42. (NVIDIA#2989) Some of the math functions on the list only appear in MLIR after LLVM 16. However, we can add support for the rest to the C++ bridge. This patch adds support for sin, cos, tan, exp, log, ceil, and floor. Signed-off-by: Eric Schweitz <eschweitz@nvidia.com> Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
bettinaheim
changed the title
bettinaheim
added
the
release notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the math functions on the list only appear in MLIR after LLVM 16. However, we can add support for the rest to the C++ bridge. This patch adds support for sin, cos, tan, exp, log, ceil, and floor.
See issue #2942