-
Notifications
You must be signed in to change notification settings - Fork 294
Support multi-diagonal operator conversion for dynamics #2993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com>
Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com>
2f366d5 to
a2fe257
Compare
Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com>
Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com>
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments but looks good to me. Thanks @1tnguyen.
- Add missing docstrings. - Rename variables for clarity. - Refactor code to reduce duplicate. Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com>
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
* Remove unused python imports and add multi-diagonal operator conversion Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com> * Code format Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com> * Fix a comment Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com> * Fix clang build Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com> * Add docs Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com> * Add docs Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com> * Address code review comments - Add missing docstrings. - Rename variables for clarity. - Refactor code to reduce duplicate. Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com> --------- Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com> Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
Description
Built upon #2986, we now enable automatic conversion from cuda-q operators (boson, spin, fermion) to cudensitymat multi-diagonal format.
Two control knobs:
Minimum dimension: ability to skip multi-diagonal (always using dense) if the sub-system dimension is less than this.
Max number of diagonals: if the number of diagonals in the multi-diagonal representation exceeds this threshold, just use dense.
Some initial performance data for the Jaynes–Cummings with various dimensions (
N) of the Fock space.i.e., 2-3x speedup.