-
Notifications
You must be signed in to change notification settings - Fork 294
Edit CUDAQ_GLOBAL_INDEX_BITS doc
#3005
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com>
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
|
Please correct me if I'm wrong but my understanding is that this variable applies to the communication network between all MPI processes regardless of whether they are intra-node or inter-node. For example, the given list would also apply to 4 nodes and 8 GPUs/node, with NVLinks between the GPUs. The current formulation makes the impression it only applies to the network between nodes and the that the network inside a node is not relevant. Here is a suggestion that reflects my understanding:
|
Edit the docstring for CUDAQ_GLOBAL_INDEX_BITS Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com>
That makes sense. I've incorporated your suggestions in 26e3801 |
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
* Edit CUDAQ_GLOBAL_INDEX_BITS doc for clarity Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com> * Address code review comment Edit the docstring for CUDAQ_GLOBAL_INDEX_BITS Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com> --------- Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com> Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
Description
Edit the documentation for
CUDAQ_GLOBAL_INDEX_BITSto improve clarity.