Fixes a number of bugs, todos, etc. #3083
Merged
+129
−95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Reorder two QIR codegen passes to avoid silly inefficiency. - Fix a bug for when the lookup fails. - Add guard to avoid crash. - Reorganize apply specialization to prop constants before generating control, adjoint, both functions rather than after. - Make the filter less aggressive. - Add CG dialect. - Change the patterns for use with greedy. Signed-off-by: Eric Schweitz <eschweitz@nvidia.com>
schweitzpgi
requested review from
1tnguyen,
annagrin,
bmhowe23 and
khalatepradnya
and removed request for
bmhowe23
1tnguyen
reviewed
Jun 26, 2025
Signed-off-by: Eric Schweitz <eschweitz@nvidia.com>
profile. Assuming these should be folded. However, they are now
turning up in python/tests/mlir/target/{graph_coloring,qspan_slices}.py
Signed-off-by: Eric Schweitz <eschweitz@nvidia.com>
Signed-off-by: Eric Schweitz <eschweitz@nvidia.com>
Signed-off-by: Eric Schweitz <eschweitz@nvidia.com>
TODO: mapping needs to be redone to be composable. Signed-off-by: Eric Schweitz <eschweitz@nvidia.com>
Signed-off-by: Eric Schweitz <eschweitz@nvidia.com>
bettinaheim
changed the title
atgeller
pushed a commit
to atgeller/cuda-quantum
that referenced
this pull request
Jul 31, 2025
* [core] Fixes a number of bugs, TODOs, etc. - Reorder two QIR codegen passes to avoid silly inefficiency. - Fix a bug for when the lookup fails. - Add guard to avoid crash. - Reorganize apply specialization to prop constants before generating control, adjoint, both functions rather than after. - Make the filter less aggressive. - Add CG dialect. - Change the patterns for use with greedy. * Eliminate variable per code review. * Add `private` for filtering out unused functions. * Fix mapping to deal with multiple functions being present in a module. TODO: mapping needs to be redone to be composable. --------- Signed-off-by: Eric Schweitz <eschweitz@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.