-
Notifications
You must be signed in to change notification settings - Fork 294
Update Grover's algorithm with phase oracle #3125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uploaded the documentation file Signed-off-by: BorisTsv <74844621+BorisTsv@users.noreply.github.com>
Signed-off-by: Monica VanDieren <150082832+mmvandieren@users.noreply.github.com>
Signed-off-by: Monica VanDieren <150082832+mmvandieren@users.noreply.github.com>
Signed-off-by: Sachin Pisal <spisal@nvidia.com>
Command Bot: Processing... |
Signed-off-by: Sachin Pisal <spisal@nvidia.com>
Command Bot: Processing... |
Signed-off-by: Sachin Pisal <spisal@nvidia.com>
…quantum into grovers-algorithm
Command Bot: Processing... |
schweitzpgi
reviewed
Jun 30, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
schweitzpgi
approved these changes
Jun 30, 2025
atgeller
pushed a commit
to atgeller/cuda-quantum
that referenced
this pull request
Jul 31, 2025
* Add files via upload Uploaded the documentation file Signed-off-by: BorisTsv <74844621+BorisTsv@users.noreply.github.com> * added images, supporting files, and placed in appropriate folders * grovers algorithm * Add files via upload Signed-off-by: Monica VanDieren <150082832+mmvandieren@users.noreply.github.com> * rewrote grovers with phase oracle Signed-off-by: Monica VanDieren <150082832+mmvandieren@users.noreply.github.com> * fix spelling Signed-off-by: Sachin Pisal <spisal@nvidia.com> * fix spelling Signed-off-by: Sachin Pisal <spisal@nvidia.com> --------- Signed-off-by: BorisTsv <74844621+BorisTsv@users.noreply.github.com> Signed-off-by: Monica VanDieren <150082832+mmvandieren@users.noreply.github.com> Signed-off-by: Sachin Pisal <spisal@nvidia.com> Co-authored-by: BorisTsv <74844621+BorisTsv@users.noreply.github.com> Co-authored-by: Sachin Pisal <spisal@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
the algorithm had a mixture of boolean and phase oracle. changed everything to be consistent and correct