Support for submission to OQC backends #435

jfriel-oqc · 2023-07-18T17:01:42Z

Description

Adding the server helper for OQC and tets.

Some particular points:

is it worth rebuilding the tests for restful helpers paramtrised? There seemed nothing specific to me bar the credentials
Had to modify the executor to cover the behaviour that we don't return ID's on submission because ID's are fetched before. Will make this change on our end, it makes sense. So hopefully this change is okay as a temporary measure
Tested python locally and passing, as it breaks CI as noted
Haven't updated docs as I don't think anything needs to change here without a platform? Please let me know otherwise

github-actions · 2023-07-18T17:02:00Z

CLA Assistant Lite bot All Contributors have signed the CLA.

jfriel-oqc · 2023-07-20T12:04:57Z

I have read the Contributor License Agreement and I hereby accept the Terms.

python/tests/backends/test_oqc.py

bmhowe23

I had to make a few changes to be able to execute the mock server tests. Please take a look at the comments and let me know what you think. After making these changes [*], I am still getting some failing tests, so depending on what additional changes are made, there may still be additional issues to resolve.

[*] I also merged in the latest from main , and I'd recommend that you also do so. I think it went fairly smoothly (as far as I can tell).

FWIW, the failures remaining after that are:

[  FAILED  ] oqc_OQCTester.checkObserveSync
[  FAILED  ] oqc_OQCTester.checkObserveAsync
[  FAILED  ] oqc_OQCTester.checkObserveAsyncLoadFromFile

unittests/backends/oqc/CMakeLists.txt

unittests/backends/oqc/OQCTester.cpp

bmhowe23 · 2023-08-25T19:51:32Z

/ok to test

Command Bot: Processing...

github-actions · 2023-08-25T20:12:56Z

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

bmhowe23 · 2023-08-25T21:28:13Z

/ok to test

Command Bot: Processing...

github-actions · 2023-08-25T21:51:26Z

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

bmhowe23

Overall it's looking pretty good. I just have a few questions, and it looks like some of the oqc-tests are failing for me. (Those are the server helper tests, which are not run by default.)

root@docker-desktop:/workspaces/cuda-quantum/build# ctest -R oqc-tests --output-on-failure
[  FAILED  ] oqc_OQCTester.checkObserveSync
[  FAILED  ] oqc_OQCTester.checkObserveAsync
[  FAILED  ] oqc_OQCTester.checkObserveAsyncLoadFromFile

runtime/cudaq/builder/kernels.h

unittests/CMakeLists.txt

unittests/integration/builder_tester.cpp

runtime/cudaq/platform/default/rest/helpers/oqc/OQCServerHelp.cpp

bmhowe23 · 2023-08-30T16:01:56Z

/ok to test

Command Bot: Processing...

…ions

bmhowe23 · 2023-09-01T17:26:48Z

/ok to test

Command Bot: Processing...

github-actions · 2023-09-01T17:51:22Z

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions · 2023-09-05T12:53:44Z

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

python/tests/backends/test_oqc.py

Co-authored-by: Ben Howe <141149032+bmhowe23@users.noreply.github.com>

bmhowe23 · 2023-09-06T11:02:43Z

/ok to test

Command Bot: Processing...

github-actions · 2023-09-06T11:26:34Z

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

bmhowe23 · 2023-09-07T19:56:39Z

With today's updates to the OQC backend, I was able to get our cuda-quantum integration tests to complete on the OQC sandbox. (Thanks for your help!) Please a) merge the latest from main into this PR branch, and b) incorporate these updates to correct the parsing issues. Note that one of the updates was to PLATFORM_LOWERING_CONFIG to account for other changes that have made it into the main branch since this PR started.

…tion

copy-pr-bot · 2023-09-08T10:24:24Z

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

bmhowe23 · 2023-09-08T12:07:36Z

/ok to test

Command Bot: Processing...

github-actions · 2023-09-08T12:31:34Z

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

utils/mock_qpu/oqc/__init__.py

bmhowe23 · 2023-09-08T14:28:14Z

Here are some suggested updates to resolve all of the current CI issues. Note that you likely need to apply the prior update in order for this patch to apply cleanly.

…ove server helper results handling and correct to entry_point and EntryPoint in mock qpu.

bmhowe23 · 2023-09-08T15:00:09Z

/ok to test

Command Bot: Processing...

github-actions · 2023-09-08T15:21:44Z

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

bmhowe23

If we can get one (hopefully) final merge-down from main, we can get this pushed in today. Thanks for all your support on this!

bmhowe23 · 2023-09-08T16:12:11Z

/ok to test

Command Bot: Processing...

cuda-quantum-bot added a commit that referenced this pull request Jul 24, 2023

@jfriel-oqc has signed the CLA from Pull Request #435

dc469b9

amccaskey reviewed Jul 28, 2023

View reviewed changes

python/tests/backends/test_oqc.py Outdated Show resolved Hide resolved

bmhowe23 reviewed Aug 16, 2023

View reviewed changes

unittests/backends/oqc/CMakeLists.txt Outdated Show resolved Hide resolved

unittests/backends/oqc/CMakeLists.txt Outdated Show resolved Hide resolved

unittests/backends/oqc/OQCTester.cpp Outdated Show resolved Hide resolved

owen arnold and others added 2 commits August 25, 2023 15:56

OQC integration through rest server helper

fd30f07

Remove python CI skip

bd2397e

oarnold-oqc force-pushed the feature/oqc_integration branch from bf0e1dd to bd2397e Compare August 25, 2023 14:57

Fix file paths and casing

922affb

github-actions bot pushed a commit that referenced this pull request Aug 25, 2023

Docs preview for PR #435.

723d156

github-actions bot pushed a commit that referenced this pull request Aug 25, 2023

Docs preview for PR #435.

1cd1557

bmhowe23 reviewed Aug 28, 2023

View reviewed changes

runtime/cudaq/builder/kernels.h Show resolved Hide resolved

unittests/CMakeLists.txt Show resolved Hide resolved

unittests/integration/builder_tester.cpp Outdated Show resolved Hide resolved

oarnold-oqc force-pushed the feature/oqc_integration branch from ae305c1 to b3808ad Compare August 28, 2023 20:52

Nvidia format and PR led cleanup

9c923e2

oarnold-oqc force-pushed the feature/oqc_integration branch from b3808ad to 9c923e2 Compare August 28, 2023 21:15

owen arnold added 2 commits August 28, 2023 22:16

Revert changes pi related definitions used

85b27c0

Remove file removal from tests

323d64d

1tnguyen reviewed Aug 29, 2023

View reviewed changes

runtime/cudaq/platform/default/rest/helpers/oqc/OQCServerHelp.cpp Outdated Show resolved Hide resolved

1tnguyen reviewed Aug 29, 2023

View reviewed changes

runtime/cudaq/platform/default/rest/helpers/oqc/OQCServerHelp.cpp Outdated Show resolved Hide resolved

1tnguyen reviewed Aug 29, 2023

View reviewed changes

runtime/cudaq/platform/default/rest/helpers/oqc/OQCServerHelp.cpp Outdated Show resolved Hide resolved

1tnguyen reviewed Aug 29, 2023

View reviewed changes

runtime/cudaq/platform/default/rest/helpers/oqc/OQCServerHelp.cpp Outdated Show resolved Hide resolved

Improve private function names and comments and compress common funct…

24d8e11

…ions

github-actions bot pushed a commit that referenced this pull request Sep 1, 2023

Docs preview for PR #435.

96abc39

github-actions bot pushed a commit that referenced this pull request Sep 5, 2023

Docs preview for PR #435.

7c7f9e5

bmhowe23 reviewed Sep 5, 2023

View reviewed changes

python/tests/backends/test_oqc.py Outdated Show resolved Hide resolved

avoid credentials temp file in target configuration

78a689c

Co-authored-by: Ben Howe <141149032+bmhowe23@users.noreply.github.com>

github-actions bot pushed a commit that referenced this pull request Sep 6, 2023

Docs preview for PR #435.

23b419b

Merge remote-tracking branch 'upstream/main' into feature/oqc_integra…

e88c745

…tion

github-actions bot pushed a commit that referenced this pull request Sep 8, 2023

Docs preview for PR #435.

3b32e7f

bmhowe23 reviewed Sep 8, 2023

View reviewed changes

utils/mock_qpu/oqc/__init__.py Outdated Show resolved Hide resolved

bmhowe23 reviewed Sep 8, 2023

View reviewed changes

utils/mock_qpu/oqc/__init__.py Outdated Show resolved Hide resolved

Fix changes with PLATFORM_LOWERING_CONFIG after merge from main. Impr…

99513e1

…ove server helper results handling and correct to entry_point and EntryPoint in mock qpu.

github-actions bot pushed a commit that referenced this pull request Sep 8, 2023

Docs preview for PR #435.

7f48825

bmhowe23 approved these changes Sep 8, 2023

View reviewed changes

Merge branch 'NVIDIA:main' into feature/oqc_integration

5f9c7c4

bmhowe23 enabled auto-merge (squash) September 8, 2023 16:30

bmhowe23 merged commit 97df76c into NVIDIA:main Sep 8, 2023

github-actions bot locked and limited conversation to collaborators Sep 8, 2023

bettinaheim added this to the release 0.4.1 milestone Sep 27, 2023

bettinaheim changed the title ~~OQC integration through rest server helper~~ Support for submission to OQC backends Nov 15, 2023

bettinaheim added enhancement New feature or request no release notes Don't list this PR in the release notes labels Nov 15, 2023

Support for submission to OQC backends #435

Support for submission to OQC backends #435

Uh oh!

Conversation

jfriel-oqc commented Jul 18, 2023

Description

Uh oh!

github-actions bot commented Jul 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jfriel-oqc commented Jul 20, 2023

Uh oh!

Uh oh!

bmhowe23 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bmhowe23 commented Aug 25, 2023 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Aug 25, 2023

Uh oh!

bmhowe23 commented Aug 25, 2023 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Aug 25, 2023

Uh oh!

bmhowe23 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bmhowe23 commented Aug 30, 2023 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bmhowe23 commented Sep 1, 2023 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Sep 1, 2023

Uh oh!

github-actions bot commented Sep 5, 2023

Uh oh!

Uh oh!

bmhowe23 commented Sep 6, 2023 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Sep 6, 2023

Uh oh!

bmhowe23 commented Sep 7, 2023

Uh oh!

copy-pr-bot bot commented Sep 8, 2023

Uh oh!

bmhowe23 commented Sep 8, 2023 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Sep 8, 2023

Uh oh!

Uh oh!

Uh oh!

bmhowe23 commented Sep 8, 2023

Uh oh!

bmhowe23 commented Sep 8, 2023 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Sep 8, 2023

Uh oh!

bmhowe23 left a comment

Choose a reason for hiding this comment

Uh oh!

bmhowe23 commented Sep 8, 2023 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

github-actions bot commented Jul 18, 2023 •

edited

Loading

bmhowe23 commented Aug 25, 2023 •

edited by github-actions bot

Loading

bmhowe23 commented Aug 25, 2023 •

edited by github-actions bot

Loading

bmhowe23 commented Aug 30, 2023 •

edited by github-actions bot

Loading

bmhowe23 commented Sep 1, 2023 •

edited by github-actions bot

Loading

bmhowe23 commented Sep 6, 2023 •

edited by github-actions bot

Loading

bmhowe23 commented Sep 8, 2023 •

edited by github-actions bot

Loading

bmhowe23 commented Sep 8, 2023 •

edited by github-actions bot

Loading

bmhowe23 commented Sep 8, 2023 •

edited by github-actions bot

Loading