KEMBAR78
Add more support for std::vector and (C style) arrays. by schweitzpgi · Pull Request #714 · NVIDIA/cuda-quantum · GitHub
Skip to content

Add more support for std::vector and (C style) arrays. #714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 29, 2023
Merged

Add more support for std::vector and (C style) arrays. #714

merged 1 commit into from
Sep 29, 2023

Conversation

@schweitzpgi
Copy link
Collaborator

@schweitzpgi schweitzpgi commented Sep 28, 2023 •
edited
Loading

This relates to issue #490. These changes help pave the way for using std::vector<bool>, bool[N], and AT[N] typed local variables in quantum kernels.

@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Sep 28, 2023
@cuda-quantum-bot
Docs preview for PR #714.
6f34a8c
bmhowe23
bmhowe23 reviewed Sep 28, 2023
View reviewed changes
bmhowe23
bmhowe23 approved these changes Sep 29, 2023
View reviewed changes
Copy link
Collaborator

@bmhowe23 bmhowe23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a few comments below.

@schweitzpgi schweitzpgi enabled auto-merge (squash) September 29, 2023 14:36
@schweitzpgi
Add more support for std::vector and (C style) arrays.
c98dba7 
This relates to issue NVIDIA#490. These changes help pave the way for using
std::vector<bool>, bool[N], and AT[N] typed local variables in quantum
kernels.

Fix and add new test.

Extend test per review comment.
@schweitzpgi schweitzpgi added this to the release 0.5.0 milestone Sep 29, 2023
@schweitzpgi schweitzpgi added the enhancement New feature or request label Sep 29, 2023
@schweitzpgi schweitzpgi merged commit 7c7e7f0 into NVIDIA:main Sep 29, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Sep 29, 2023
@schweitzpgi schweitzpgi deleted the ch-vector.e2e branch September 29, 2023 17:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@bmhowe23 bmhowe23 bmhowe23 approved these changes

@1tnguyen 1tnguyen Awaiting requested review from 1tnguyen

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

release 0.5.0

Development

Successfully merging this pull request may close these issues.

2 participants

@schweitzpgi @bmhowe23