-
Notifications
You must be signed in to change notification settings - Fork 294
Additional kernels for chemistry applications #731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…rder to support controlled givens rotations
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. You'll probably want someone more conversant in the algorithms to look at it.
Otherwise, just a few nits found under the microscope. :)
Co-authored-by: Eric Schweitz <eschweitz@nvidia.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just a few minor comments 👍
- Randomized tests => sweep tests (they are fast) - Removed empty Doxygen comments
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
Description
This PR adds Givens rotation and Fermionic SWAP kernels as requested in #586.
Add fermionic swap gates and givens rotations as a header only C++ library that defines device kernels.
Overload for
kernel_builder+ Python use.Add support for controlled
exp_pauliin simulators so thatcudaq::controlworks for givens rotation.Adjust
exp_pauliangle scaling in qpp simulator match the math: