-
Notifications
You must be signed in to change notification settings - Fork 294
Limited support for executing loops with break statements on quantum hardware backends #768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
250f057 to
d4529c0
Compare
d4529c0 to
1b0f37d
Compare
Collaborator
Author
Command Bot: Processing... |
1b0f37d to
993167c
Compare
Collaborator
Author
Command Bot: Processing... |
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
bmhowe23
reviewed
Oct 16, 2023
8a02037 to
5c32840
Compare
Collaborator
Author
Command Bot: Processing... |
Add an option to the unrolling pass and unrolling pass pipeline to allow loops with `break` statements to be fully unrolled, so long as the loop is otherwise, structurally speaking, like a regular counted loop. Since the total number of executions is a variable, the option allows one to selectively enable/disable the unrolling of these variable iteration, constant upper bound loops. Fix bug with default for testing for an invariant loop. Guard against unrolling a loop with zero iterations. remove old comment per review
5c32840 to
42461a6
Compare
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
bmhowe23
approved these changes
Oct 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an option to the unrolling pass and unrolling pass pipeline to allow loops with
breakstatements to be fully unrolled, so long as the loop is otherwise, structurally speaking, like a regular counted loop. Since the total number of executions is a variable, the option allows one to selectively enable/disable the unrolling of these variable iteration, constant upper bound loops.