KEMBAR78
Support for additional controlled gates in python by anthony-santana · Pull Request #784 · NVIDIA/cuda-quantum · GitHub
Skip to content

Support for additional controlled gates in python #784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Oct 18, 2023
Merged

Support for additional controlled gates in python #784

merged 10 commits into from
Oct 18, 2023

Conversation

@anthony-santana
Copy link
Collaborator

@anthony-santana anthony-santana commented Oct 16, 2023 •
edited
Loading

Description

Closes #723
Closes #751

  • Binds the controlled versions of: r1, rx, ry, rz to python
  • New python unit tests for existing: cx, cy, cz, ch, cs, ct
  • New python compiler tests for existing: cx, cy, cz, ch, cs, ct
  • New python unit tests for r1, rx, ry, rz
  • New python compiler tests for r1, rx, ry, rz
  • Update existing python documentation and tests to reflect that we can now pass a register of controls to our c-gates

What this PR doesn't address:

  • A follow-up PR will handle the controlled SWAP implementation in the C++/python builder

@copy-pr-bot
Copy link

copy-pr-bot bot commented Oct 16, 2023

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@anthony-santana
Copy link
Collaborator Author

anthony-santana commented Oct 16, 2023 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@anthony-santana anthony-santana force-pushed the controlled_gates branch 2 times, most recently from c52bb6f to f86a325 Compare October 17, 2023 20:12
@anthony-santana anthony-santana marked this pull request as ready for review October 17, 2023 20:33
@anthony-santana
Copy link
Collaborator Author

anthony-santana commented Oct 17, 2023 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Oct 17, 2023
@cuda-quantum-bot
Docs preview for PR #784.
2a46e4d
schweitzpgi
schweitzpgi reviewed Oct 17, 2023
View reviewed changes
Copy link
Collaborator

@schweitzpgi schweitzpgi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Just need to tweak the tests a tad.

@anthony-santana
Copy link
Collaborator Author

anthony-santana commented Oct 17, 2023 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Oct 17, 2023
@cuda-quantum-bot
Docs preview for PR #784.
1ef9524
@schweitzpgi
Copy link
Collaborator

schweitzpgi commented Oct 18, 2023 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Oct 18, 2023
@cuda-quantum-bot
Docs preview for PR #784.
f6e26ce
@anthony-santana
everything except controlled swaps
1242a55 
Signed-off-by: A.M. Santana <anthonys@nvidia.com>
@anthony-santana
forgot the parameter annotations
5806e53 
Signed-off-by: A.M. Santana <anthonys@nvidia.com>
@anthony-santana
add keywords back to compiler test
3a3b0be 
Signed-off-by: A.M. Santana <anthonys@nvidia.com>
@anthony-santana
swap implementation
19159b3 
Signed-off-by: A.M. Santana <anthonys@nvidia.com>
@anthony-santana
remove swap work for separate pr
b1311e1 
Signed-off-by: A.M. Santana <anthonys@nvidia.com>
@anthony-santana
format compiler test
d9dc074 
Signed-off-by: A.M. Santana <anthonys@nvidia.com>
@anthony-santana
incorrect filecheck string
ef7a7ce 
Signed-off-by: A.M. Santana <anthonys@nvidia.com>
@anthony-santana
hard coded kernel names in filecheck
1189a54 
Signed-off-by: A.M. Santana <anthonys@nvidia.com>
@anthony-santana
forgot to add new gates to api docs
8e79d78 
Signed-off-by: A.M. Santana <anthonys@nvidia.com>
@anthony-santana
Copy link
Collaborator Author

anthony-santana commented Oct 18, 2023 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Oct 18, 2023
@cuda-quantum-bot
Docs preview for PR #784.
d7fa4e9
@anthony-santana
replace references to doubles with floats in python docs
b0d105e 
Signed-off-by: A.M. Santana <anthonys@nvidia.com>
@anthony-santana
Copy link
Collaborator Author

anthony-santana commented Oct 18, 2023 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@anthony-santana anthony-santana enabled auto-merge (squash) October 18, 2023 16:16
@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Oct 18, 2023
@cuda-quantum-bot
Docs preview for PR #784.
03234d1
@anthony-santana anthony-santana merged commit 03a98d4 into NVIDIA:main Oct 18, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Oct 18, 2023
@anthony-santana anthony-santana deleted the controlled_gates branch October 18, 2023 21:32
@bettinaheim bettinaheim changed the title Support for controlled gates in python Support for additional controlled gates in python Nov 15, 2023
@bettinaheim bettinaheim added enhancement New feature or request release notes Changes need to be captured in the release notes and removed enhancement New feature or request labels Nov 15, 2023
@bettinaheim bettinaheim added this to the release 0.5.0 milestone Nov 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@schweitzpgi schweitzpgi schweitzpgi approved these changes

Assignees

No one assigned

Labels

release notes Changes need to be captured in the release notes

Projects

None yet

Milestone

release 0.5.0

Development

Successfully merging this pull request may close these issues.

No c<op> defined for the ry gate Support applying controlled parametrized gates in kernel_builder with double

3 participants

@anthony-santana @schweitzpgi @bettinaheim