Fix #781: Handle loops that include mid-circuit measurements #787
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
…asurement. Due to an interaction between the revised memtoreg pass and loop unrolling, the test with a mid-circuit measurement and a break statement still wasn't being unrolled. These changes fix that issue. Primarily, these changes allow structured operations that accept region arguments to straddle the fence and allow some values to be promoted as dominating uses (when only used) while other values to be threaded as region arguments exactly as before (when written). This change simplifies the register-semantics IR. There may be a bit of performance lossage in memtoreg as a result however as promoted values may later be discovered to be written and the changes will need to be reapplied. Leave static unrolling pass in the kernel builder.
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
bettinaheim
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to an interaction between the revised memtoreg pass and loop unrolling, the test with a mid-circuit measurement and a break statement still wasn't being unrolled. These changes fix that issue.
Primarily, these changes allow structured operations that accept region arguments to straddle the fence and allow some values to be promoted as dominating uses (when only used) while other values to be threaded as region arguments exactly as before (when written). This change simplifies the register-semantics IR. There may be a bit of performance lossage in memtoreg as a result however as promoted values may later be discovered to be written and the changes will need to be reapplied.