KEMBAR78
Removing password prompt and other ergonomic changes for Docker images by bettinaheim · Pull Request #820 · NVIDIA/cuda-quantum · GitHub
Skip to content

Removing password prompt and other ergonomic changes for Docker images #820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 49 commits into from
Nov 8, 2023
Merged

Removing password prompt and other ergonomic changes for Docker images #820

merged 49 commits into from
Nov 8, 2023

Conversation

@bettinaheim
Copy link
Collaborator

@bettinaheim bettinaheim commented Oct 24, 2023 •
edited
Loading

This PR:

  • Adds a script to download the vs code cli and initiate a tunnel to the cudaq.ext image, as well as additional configurations to facilitate using either VS Code or Jupyterlab in DGX Cloud.
  • Eliminates the password prompt when using sudo, addressing the need for docs mentioned in the first item in Add documentation for how to install additional software in the Docker container #748 and the feedback that the sudo_root manual is mentioned but not installed.

Maintenance:

  • The PR reenables the signing of the NGC image
  • Having files be executable is not very friendly across different platforms. I hence additionally updated permissions + cmake files to not require that.

bettinaheim
bettinaheim commented Oct 24, 2023
View reviewed changes
bettinaheim
bettinaheim commented Oct 24, 2023
View reviewed changes
@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Oct 24, 2023
@cuda-quantum-bot
Docs preview for PR #820.
a0586f9
@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Oct 24, 2023
@cuda-quantum-bot
Docs preview for PR #820.
201f637
@bettinaheim bettinaheim temporarily deployed to ghcr-deployment October 24, 2023 12:41 — with GitHub Actions Inactive
@bettinaheim bettinaheim temporarily deployed to ghcr-deployment October 24, 2023 12:44 — with GitHub Actions Inactive
@bettinaheim bettinaheim temporarily deployed to ghcr-deployment October 24, 2023 12:44 — with GitHub Actions Inactive
@bettinaheim bettinaheim temporarily deployed to ghcr-deployment October 24, 2023 12:44 — with GitHub Actions Inactive
@bettinaheim bettinaheim temporarily deployed to ghcr-deployment October 24, 2023 12:44 — with GitHub Actions Inactive
@bettinaheim bettinaheim temporarily deployed to ghcr-deployment October 24, 2023 12:44 — with GitHub Actions Inactive
@bettinaheim bettinaheim temporarily deployed to ghcr-deployment October 24, 2023 12:44 — with GitHub Actions Inactive
@bettinaheim bettinaheim temporarily deployed to ghcr-deployment October 24, 2023 12:44 — with GitHub Actions Inactive
@bettinaheim bettinaheim temporarily deployed to ghcr-deployment October 24, 2023 12:44 — with GitHub Actions Inactive
@bettinaheim bettinaheim temporarily deployed to ghcr-deployment October 24, 2023 12:59 — with GitHub Actions Inactive
@bettinaheim bettinaheim temporarily deployed to ghcr-deployment October 24, 2023 13:02 — with GitHub Actions Inactive
@bettinaheim bettinaheim temporarily deployed to ghcr-deployment October 24, 2023 13:02 — with GitHub Actions Inactive
@bettinaheim bettinaheim temporarily deployed to ghcr-deployment October 24, 2023 13:02 — with GitHub Actions Inactive
@bettinaheim bettinaheim temporarily deployed to ghcr-deployment October 24, 2023 13:02 — with GitHub Actions Inactive
@bettinaheim bettinaheim added this to the release 0.5.0 milestone Nov 6, 2023
bmhowe23
bmhowe23 reviewed Nov 6, 2023
View reviewed changes
@github-actions
Copy link

github-actions bot commented Nov 8, 2023

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Nov 8, 2023
@cuda-quantum-bot
Docs preview for PR #820.
efa639c
@bettinaheim bettinaheim enabled auto-merge (squash) November 8, 2023 11:51
@bettinaheim bettinaheim merged commit c329115 into main Nov 8, 2023
@bettinaheim bettinaheim deleted the preview branch November 8, 2023 12:47
@github-actions github-actions bot locked and limited conversation to collaborators Nov 8, 2023
bmhowe23
bmhowe23 reviewed Nov 8, 2023
View reviewed changes
docs/sphinx/examples/cpp/algorithms/bernstein_vazirani.cpp
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this new file might be causing publishing to fail: https://github.com/NVIDIA/cuda-quantum/actions/runs/6800592761/job/18491760634

terminate called after throwing an instance of 'std::runtime_error'
  what():  [custatevec] %out of memory in addQubitsToState (line 207)
Aborted (core dumped)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@khalatepradnya also pointed that out. Could you just set the qubits to 28? I didn't think to update it and forgot some GPUs will have less memory.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@khalatepradnya also pointed that out. Could you just set the qubits to 28? I didn't think to update it and forgot some GPUs will have less memory.

Yes, will do.

@bettinaheim bettinaheim added the release notes Changes need to be captured in the release notes label Nov 15, 2023
@bettinaheim bettinaheim changed the title Ergonomic changes for Docker images Removing password prompt and other ergonomic changes for Docker images Nov 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@bmhowe23 bmhowe23 bmhowe23 approved these changes

@amccaskey amccaskey Awaiting requested review from amccaskey

Assignees

No one assigned

Labels

release notes Changes need to be captured in the release notes

Projects

None yet

Milestone

release 0.5.0

Development

Successfully merging this pull request may close these issues.

2 participants

@bettinaheim @bmhowe23