KEMBAR78
Enable while loop normalization and unrolling by schweitzpgi · Pull Request #830 · NVIDIA/cuda-quantum · GitHub
Skip to content

Enable while loop normalization and unrolling #830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 31, 2023
Merged

Enable while loop normalization and unrolling #830

merged 5 commits into from
Oct 31, 2023

Conversation

@schweitzpgi
Copy link
Collaborator

Builds on #824

@schweitzpgi schweitzpgi added the enhancement New feature or request label Oct 27, 2023
@schweitzpgi schweitzpgi marked this pull request as draft October 27, 2023 15:19
@schweitzpgi schweitzpgi linked an issue Oct 27, 2023 that may be closed by this pull request
Support ranged for loops, std::reverse iterator modifier, and cudaq::range #646
Closed
@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Oct 27, 2023
@cuda-quantum-bot
Docs preview for PR #830.
b769c0e
bmhowe23
bmhowe23 reviewed Oct 30, 2023
View reviewed changes
@schweitzpgi schweitzpgi marked this pull request as ready for review October 30, 2023 14:43
@schweitzpgi schweitzpgi force-pushed the ch-loop.peeling-while.unroll branch from 1d853ca to e8f2a42 Compare October 30, 2023 15:16
@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Oct 30, 2023
@cuda-quantum-bot
Docs preview for PR #830.
e0ff468
@schweitzpgi schweitzpgi force-pushed the ch-loop.peeling-while.unroll branch from fcaec3e to c2b13d0 Compare October 30, 2023 21:20
@schweitzpgi schweitzpgi added this to the release 0.5.0 milestone Oct 30, 2023
@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Oct 30, 2023
@cuda-quantum-bot
Docs preview for PR #830.
72979e0
@schweitzpgi
Enable loop normalization and loop unrolling of while loops.
5d6d121 
Togther with loop peeling, this will allow for the unrolling of while
loops and do-while loops, when the number of iterations is constant.
@schweitzpgi
Rewrite comment to reflect the current status of the code.
12fcb93
@schweitzpgi
Fix bug in loop analysis. While region ends with ConditionOp, not
800faec 
ContinueOp. Add regression tests.
@schweitzpgi
Add the while and step(optional) regions to unrolling to avoid missing
ac9101a 
any side effects that this expressions may have. In the typical case,
this code will be eliminated by DCE.
@schweitzpgi schweitzpgi force-pushed the ch-loop.peeling-while.unroll branch from c2b13d0 to ac9101a Compare October 30, 2023 22:10
@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Oct 30, 2023
@cuda-quantum-bot
Docs preview for PR #830.
7c3fed9
@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Oct 30, 2023
@cuda-quantum-bot
Docs preview for PR #830.
f132968
bmhowe23
bmhowe23 approved these changes Oct 31, 2023
View reviewed changes
@schweitzpgi schweitzpgi merged commit fb94f74 into NVIDIA:main Oct 31, 2023
@schweitzpgi schweitzpgi deleted the ch-loop.peeling-while.unroll branch October 31, 2023 16:20
@github-actions github-actions bot locked and limited conversation to collaborators Oct 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@bmhowe23 bmhowe23 bmhowe23 approved these changes

@anthony-santana anthony-santana Awaiting requested review from anthony-santana

@khalatepradnya khalatepradnya Awaiting requested review from khalatepradnya

@bettinaheim bettinaheim Awaiting requested review from bettinaheim

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

release 0.5.0

Development

Successfully merging this pull request may close these issues.

Support ranged for loops, std::reverse iterator modifier, and cudaq::range

2 participants

@schweitzpgi @bmhowe23