Open-source tensornet simulator and add tensornet-mps simulator backend #863

1tnguyen · 2023-11-06T00:14:23Z

Description

Add tensornet and mps backends based on cuquantum 23.10 release.
Modified Dockerfile to use the the latest cuquantum.
Include the new backends in the runtime test suite: escaping some tests that are not suitable for tensornet backends: conditional circuits with many shots (long test time) and multi-qubit (> 2) gates on MPS.

github-actions · 2023-11-06T01:01:57Z

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

unittests/integration/ghz_nisq_tester.cpp

github-actions · 2023-11-06T19:29:11Z

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions · 2023-11-07T20:07:16Z

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

runtime/nvqir/cutensornet/simulator_cutensornet.cpp

runtime/nvqir/cutensornet/tensornet_spin_op.cpp

runtime/nvqir/cutensornet/tensornet_state.cpp

Co-authored-by: Ben Howe <141149032+bmhowe23@users.noreply.github.com>

github-actions · 2023-11-08T04:20:12Z

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

Co-authored-by: Ben Howe <141149032+bmhowe23@users.noreply.github.com>

1tnguyen · 2023-11-09T05:06:09Z

Test logs for the runtime test suite (unittests/) for these 2 backends:

tensornet:
tensornet_test.txt
tensornet-mps:
tensornet_mps_test.txt

github-actions · 2023-11-09T21:21:01Z

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

unittests/integration/ghz_nisq_tester.cpp

bettinaheim

Lgtm

docs/sphinx/examples/cpp/basics/cutensornet_backends.cpp

@bmhowe23

Thanks @bmhowe23 for spotting them. - Dead `default` switch case. Clang doesn't like it. - Missing a default virtual destructor and one inconsistent declaration. - Update the example to be generic with/without cutensornet MPI support.

github-actions · 2023-11-09T22:31:32Z

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions · 2023-11-09T23:00:50Z

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

bmhowe23

Thanks, Thien 👍

khalatepradnya · 2023-11-09T23:36:11Z

Q: Do these simulator backends have configuration files?

1tnguyen · 2023-11-09T23:41:44Z

Q: Do these simulator backends have configuration files?

Yes, they have. The config files are auto generated and installed by CMake.

github-actions · 2023-11-09T23:50:37Z

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

1tnguyen added 2 commits November 6, 2023 11:13

Add cutensornet-based simulator backends

34b1168

Fix code format

6edf1cd

1tnguyen mentioned this pull request Nov 6, 2023

Remove tensornet from downstream pipeline #864

Merged

github-actions bot pushed a commit that referenced this pull request Nov 6, 2023

Docs preview for PR #863.

33957e3

1tnguyen had a problem deploying to ghcr-deployment November 6, 2023 02:03 — with GitHub Actions Failure

1tnguyen marked this pull request as ready for review November 6, 2023 03:47

1tnguyen requested review from amccaskey, anthony-santana, bettinaheim, bmhowe23 and schweitzpgi November 6, 2023 03:47

bmhowe23 reviewed Nov 6, 2023

View reviewed changes

unittests/integration/ghz_nisq_tester.cpp Show resolved Hide resolved

Missing Python cuquantum dependency version bump

6198aaa

1tnguyen added this to the release 0.5.0 milestone Nov 6, 2023

github-actions bot pushed a commit that referenced this pull request Nov 6, 2023

Docs preview for PR #863.

e71cc88

Update code comments

96d9f6f

github-actions bot pushed a commit that referenced this pull request Nov 7, 2023

Docs preview for PR #863.

0e77134

bmhowe23 reviewed Nov 8, 2023

View reviewed changes

1tnguyen and others added 2 commits November 8, 2023 14:54

Update runtime/nvqir/cutensornet/tensornet_state.cpp

68ef6c2

Co-authored-by: Ben Howe <141149032+bmhowe23@users.noreply.github.com>

Address code review comments

433d44d

github-actions bot pushed a commit that referenced this pull request Nov 8, 2023

Docs preview for PR #863.

04d0e93

1tnguyen and others added 4 commits November 9, 2023 08:42

Update runtime/nvqir/cutensornet/tensornet_state.cpp

35dfefe

Co-authored-by: Ben Howe <141149032+bmhowe23@users.noreply.github.com>

Refactor MPI support code in tensornet backend

d67b1c0

Merge branch 'main' into tnguyen/tensornet

e1a7c20

update a code comment for clarity

d743684

Merge branch 'main' into tnguyen/tensornet

46662ab

github-actions bot pushed a commit that referenced this pull request Nov 9, 2023

Docs preview for PR #863.

4375b10

bettinaheim mentioned this pull request Nov 9, 2023

Add support for random seed in tensornet and tensornet-mps backends #895

Closed

bettinaheim reviewed Nov 9, 2023

View reviewed changes

unittests/integration/ghz_nisq_tester.cpp Show resolved Hide resolved

Update unittests/integration/ghz_nisq_tester.cpp

edba307

bettinaheim approved these changes Nov 9, 2023

View reviewed changes

bmhowe23 reviewed Nov 9, 2023

View reviewed changes

docs/sphinx/examples/cpp/basics/cutensornet_backends.cpp Outdated Show resolved Hide resolved

Fix a couple of compiler warnings on Clang

f2bdf37

Thanks @bmhowe23 for spotting them. - Dead `default` switch case. Clang doesn't like it. - Missing a default virtual destructor and one inconsistent declaration. - Update the example to be generic with/without cutensornet MPI support.

github-actions bot pushed a commit that referenced this pull request Nov 9, 2023

Docs preview for PR #863.

88d8850

escape code comments from spell checking

1716b88

github-actions bot pushed a commit that referenced this pull request Nov 9, 2023

Docs preview for PR #863.

f2951ad

bmhowe23 approved these changes Nov 9, 2023

View reviewed changes

github-actions bot pushed a commit that referenced this pull request Nov 9, 2023

Docs preview for PR #863.

8b532aa

1tnguyen merged commit a8123e4 into NVIDIA:main Nov 9, 2023

github-actions bot locked and limited conversation to collaborators Nov 9, 2023

bettinaheim added the enhancement New feature or request label Nov 15, 2023

bettinaheim changed the title ~~Add cutensornet-based simulator backends~~ Open-source tensornet simulator and add tensornet-mps simulator backend. Nov 15, 2023

bettinaheim changed the title ~~Open-source tensornet simulator and add tensornet-mps simulator backend.~~ Open-source tensornet simulator and add tensornet-mps simulator backend Nov 15, 2023

bettinaheim added the no release notes Don't list this PR in the release notes label Nov 15, 2023

Open-source tensornet simulator and add tensornet-mps simulator backend #863

Open-source tensornet simulator and add tensornet-mps simulator backend #863

Uh oh!

Conversation

1tnguyen commented Nov 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

github-actions bot commented Nov 6, 2023

Uh oh!

Uh oh!

github-actions bot commented Nov 6, 2023

Uh oh!

github-actions bot commented Nov 7, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Nov 8, 2023

Uh oh!

1tnguyen commented Nov 9, 2023

Uh oh!

github-actions bot commented Nov 9, 2023

Uh oh!

Uh oh!

bettinaheim left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Nov 9, 2023

Uh oh!

github-actions bot commented Nov 9, 2023

Uh oh!

bmhowe23 left a comment

Choose a reason for hiding this comment

Uh oh!

khalatepradnya commented Nov 9, 2023

Uh oh!

1tnguyen commented Nov 9, 2023

Uh oh!

github-actions bot commented Nov 9, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

1tnguyen commented Nov 6, 2023 •

edited

Loading