KEMBAR78
Allow the environment variable to override the default target by khalatepradnya · Pull Request #877 · NVIDIA/cuda-quantum · GitHub
Skip to content

Allow the environment variable to override the default target #877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Nov 10, 2023
Merged

Allow the environment variable to override the default target #877

merged 17 commits into from
Nov 10, 2023

Conversation

@khalatepradnya
Copy link
Collaborator

@khalatepradnya khalatepradnya commented Nov 7, 2023 •
edited
Loading

  • Added an environment variable 'CUDAQ_DEFAULT_SIMULATOR' to specify target
  • Check value against valid simulators
  • Added basic tests

Checklist:

  • I have added tests to cover my changes.
  • I have read the CONTRIBUTING document.

Documentation will be addressed separately.

Description

If no target specified, and environment variable is not set or invalid value, then default target is 'qpp-cpu' for CPU-only systems and 'nvidia' for GPU enabled systems.
If no target specified on command line, and environment variable set to valid value, then that value is the default target.
If target specified on command line and '--emulate' flag is set, then the default target's simulator is used at runtime.

@copy-pr-bot
Copy link

copy-pr-bot bot commented Nov 7, 2023

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@khalatepradnya khalatepradnya self-assigned this Nov 7, 2023
@khalatepradnya
Copy link
Collaborator Author

khalatepradnya commented Nov 8, 2023 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@khalatepradnya khalatepradnya marked this pull request as ready for review November 8, 2023 04:46
@khalatepradnya khalatepradnya marked this pull request as draft November 8, 2023 04:55
@github-actions
Copy link

github-actions bot commented Nov 8, 2023

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Nov 8, 2023
@cuda-quantum-bot
Docs preview for PR #877.
d0fe210
@bettinaheim bettinaheim added this to the release 0.5.0 milestone Nov 8, 2023
schweitzpgi
schweitzpgi reviewed Nov 8, 2023
View reviewed changes
Copy link
Collaborator

@schweitzpgi schweitzpgi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good.

@khalatepradnya
Copy link
Collaborator Author

khalatepradnya commented Nov 8, 2023 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

1 similar comment
@khalatepradnya
Copy link
Collaborator Author

khalatepradnya commented Nov 8, 2023 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

khalatepradnya and others added 5 commits November 8, 2023 21:18
@khalatepradnya
* Allow the environment variable override the default target
75503ed 
-- Added an environment variable - CUDAQ_DEFAULT_SIMULATOR
-- Check value against valid simulators
-- Added basic tests
@khalatepradnya
* Fix formatting for Python file
fed9259 
* Extend C++ test
@khalatepradnya
* Move the environment variable tests out of unittest set up since the
3023bff 
  environment variable isn't retained.
@khalatepradnya @schweitzpgi
Update tools/nvqpp/nvq++.in
0d38d62 
Co-authored-by: Eric Schweitz <eschweitz@nvidia.com>
@khalatepradnya
* Check environment variable and GPU availability in the
530c300 
  LinkedLibraryHolder constructor.
@khalatepradnya
Copy link
Collaborator Author

khalatepradnya commented Nov 9, 2023 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@khalatepradnya
Copy link
Collaborator Author

khalatepradnya commented Nov 9, 2023 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@khalatepradnya khalatepradnya marked this pull request as ready for review November 9, 2023 05:47
bettinaheim
bettinaheim reviewed Nov 9, 2023
View reviewed changes
bettinaheim
bettinaheim reviewed Nov 9, 2023
View reviewed changes
amccaskey
amccaskey reviewed Nov 9, 2023
View reviewed changes
bmhowe23
bmhowe23 reviewed Nov 9, 2023
View reviewed changes
bmhowe23
bmhowe23 approved these changes Nov 9, 2023
View reviewed changes
Copy link
Collaborator

@bmhowe23 bmhowe23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

schweitzpgi
schweitzpgi reviewed Nov 9, 2023
View reviewed changes
khalatepradnya and others added 3 commits November 9, 2023 14:17
@khalatepradnya @schweitzpgi
Update python/utils/LinkedLibraryHolder.cpp
0d56c83 
Co-authored-by: Eric Schweitz <eschweitz@nvidia.com>
@khalatepradnya @schweitzpgi
Update python/utils/LinkedLibraryHolder.h
1b1043b 
Co-authored-by: Eric Schweitz <eschweitz@nvidia.com>
@khalatepradnya @schweitzpgi
Update python/utils/LinkedLibraryHolder.h
2e8a1f6 
Co-authored-by: Eric Schweitz <eschweitz@nvidia.com>
@khalatepradnya
Copy link
Collaborator Author

khalatepradnya commented Nov 9, 2023 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

schweitzpgi
schweitzpgi reviewed Nov 9, 2023
View reviewed changes
schweitzpgi
schweitzpgi reviewed Nov 9, 2023
View reviewed changes
@khalatepradnya
Copy link
Collaborator Author

khalatepradnya commented Nov 10, 2023 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Nov 10, 2023
@cuda-quantum-bot
Docs preview for PR #877.
5289d4e
@khalatepradnya khalatepradnya enabled auto-merge (squash) November 10, 2023 00:32
@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Nov 10, 2023
@cuda-quantum-bot
Docs preview for PR #877.
5178502
@khalatepradnya
Copy link
Collaborator Author

khalatepradnya commented Nov 10, 2023 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@khalatepradnya
Copy link
Collaborator Author

khalatepradnya commented Nov 10, 2023 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Nov 10, 2023
@cuda-quantum-bot
Docs preview for PR #877.
925bcd0
@khalatepradnya khalatepradnya merged commit df34f7f into NVIDIA:main Nov 10, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Nov 10, 2023
@khalatepradnya khalatepradnya deleted the feature/target-env-var branch November 13, 2023 19:31
@bettinaheim bettinaheim added enhancement New feature or request no release notes Don't list this PR in the release notes labels Nov 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@amccaskey amccaskey amccaskey left review comments

@schweitzpgi schweitzpgi schweitzpgi left review comments

@bmhowe23 bmhowe23 bmhowe23 approved these changes

@bettinaheim bettinaheim Awaiting requested review from bettinaheim

Assignees

@khalatepradnya khalatepradnya

Labels

enhancement New feature or request no release notes Don't list this PR in the release notes

Projects

None yet

Milestone

release 0.5.0

Development

Successfully merging this pull request may close these issues.

5 participants

@khalatepradnya @amccaskey @schweitzpgi @bettinaheim @bmhowe23