Fix an issue due to an ABI differences between ARM and x86 architectures #878
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Ben Howe <141149032+bmhowe23@users.noreply.github.com>
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
schweitzpgi
reviewed
Nov 8, 2023
Comment on lines
+522
to
+523
| mlir::LLVM::LLVMDialect::getStructRetAttrName(), | ||
| mlir::TypeAttr::get(eleTy)); |
There was a problem hiding this comment.
nit: Don't need the mlir::
bettinaheim
changed the title
sret attribute for entry point function if needed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The root cause is ABI differences b/w ARM and x86 as explained here.
Hence, this PR adds the
sretattribute to the first (hidden) argument if the entry point function is returning one and re-enables theauto_kernel.cpptest on ARM.Resolved: #553