KEMBAR78
Fixing typos and copy editing for docs by mmvandieren · Pull Request #896 · NVIDIA/cuda-quantum · GitHub
Skip to content

Conversation

@mmvandieren
Copy link
Contributor

Description

This addresses Issue number 893.
Typos and style guide changes were made to "Learn the Basics" pages.
These are documented here.

Typos and style guide changes were made to "Learn the Basics" pages.
@copy-pr-bot
Copy link

copy-pr-bot bot commented Nov 9, 2023

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions
Copy link

github-actions bot commented Nov 9, 2023

CLA Assistant Lite bot All Contributors have signed the CLA.

@mmvandieren
Copy link
Contributor Author

I have read the Contributor License Agreement and I hereby accept the Terms.

@bettinaheim
Copy link
Collaborator

bettinaheim commented Nov 9, 2023

/ok to test

Command Bot: Processing...

@bettinaheim
Copy link
Collaborator

bettinaheim commented Nov 13, 2023

/ok to test

Command Bot: Processing...

@mmvandieren
Copy link
Contributor Author

@bettinaheim I added the subsitution code to the kernel file for the emdash and committed the change. I think we're ready to try running the tests again. thanks.

mmvandieren and others added 4 commits November 13, 2023 13:32
I attempted to edit the C++ lambdas sentence to make it easier to read.  However, I may have changed the meaning; so this needs a SME review.
bettinaheim
bettinaheim previously approved these changes Nov 15, 2023
Copy link
Collaborator

@bettinaheim bettinaheim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, if the build passes

@bettinaheim
Copy link
Collaborator

bettinaheim commented Nov 15, 2023

/ok to test

Command Bot: Processing...

@bettinaheim bettinaheim dismissed their stale review November 15, 2023 09:04

Overlooked that the replacement pattern will cause a formatting issue.

@bettinaheim
Copy link
Collaborator

bettinaheim commented Nov 15, 2023

/ok to test

Command Bot: Processing...

@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Nov 15, 2023
@bettinaheim bettinaheim merged commit d69a01b into NVIDIA:main Nov 15, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Nov 15, 2023
@bettinaheim bettinaheim added the documentation Improvements or additions to documentation label Jan 22, 2024
@bettinaheim bettinaheim added this to the release 0.6.0 milestone Jan 22, 2024
@bettinaheim bettinaheim changed the title vandieren-typos Fixing typos and copy editing for docs Jan 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants