KEMBAR78
Add ability to create shared library to the driver by schweitzpgi · Pull Request #985 · NVIDIA/cuda-quantum · GitHub
Skip to content

Add ability to create shared library to the driver #985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 4, 2023
Merged

Add ability to create shared library to the driver #985

merged 3 commits into from
Dec 4, 2023

Conversation

@schweitzpgi
Copy link
Collaborator

@schweitzpgi schweitzpgi commented Nov 30, 2023 •
edited
Loading

Closes #314.

Adds PIC code flag to the required spots and allows -static and -shared flags to be passed to the linker.

@schweitzpgi schweitzpgi requested a review from 1tnguyen November 30, 2023 20:46
1tnguyen
1tnguyen approved these changes Nov 30, 2023
View reviewed changes
Copy link
Collaborator

@1tnguyen 1tnguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@schweitzpgi schweitzpgi enabled auto-merge (squash) December 1, 2023 23:28
@github-actions
Copy link

github-actions bot commented Dec 2, 2023

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Dec 2, 2023
@cuda-quantum-bot
Docs preview for PR #985.
6be445c
@schweitzpgi
Copy link
Collaborator Author

Apparently the CI container doesn't have the file command installed.

@1tnguyen
Copy link
Collaborator

1tnguyen commented Dec 4, 2023

Apparently the CI container doesn't have the file command installed.

Apparently :-) Maybe we need to add file to this line https://github.com/NVIDIA/cuda-quantum/blob/main/docker/build/devdeps.Dockerfile#L181

@schweitzpgi
Add ability to create shared library to the driver.
20bbb45 
Closes NVIDIA#314.

Adds PIC code flag to the requires spots and allows `-static` and
`-shared` flags to be passed to the linker.
@schweitzpgi
Install the file binary.
79613e4
@github-actions
Copy link

github-actions bot commented Dec 4, 2023

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Dec 4, 2023
@cuda-quantum-bot
Docs preview for PR #985.
d59736f
@schweitzpgi schweitzpgi merged commit 4ca0bc1 into NVIDIA:main Dec 4, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2023
@schweitzpgi schweitzpgi added the enhancement New feature or request label Dec 8, 2023
@schweitzpgi schweitzpgi deleted the ch-i314 branch January 2, 2024 16:02
@bettinaheim bettinaheim changed the title Add ability to create shared library to the driver. Add ability to create shared library to the driver Jan 22, 2024
@bettinaheim bettinaheim added release notes Changes need to be captured in the release notes and removed enhancement New feature or request labels Jan 22, 2024
@bettinaheim bettinaheim added this to the release 0.6.0 milestone Jan 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@1tnguyen 1tnguyen 1tnguyen approved these changes

Assignees

No one assigned

Labels

release notes Changes need to be captured in the release notes

Projects

None yet

Milestone

release 0.6.0

Development

Successfully merging this pull request may close these issues.

Build a static or shared library with nvq++

3 participants

@schweitzpgi @1tnguyen @bettinaheim