Make dlpack version easily discoverable #165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create dlpack_version.txt file containing the required dlpack version and update CMakeLists.txt to read from it instead of hardcoding the version. This addresses issue NVIDIA#164 by making the dlpack dependency version easily accessible to users and automated build systems without requiring manual parsing of CMake files. Fixes NVIDIA#164 Signed-off-by: Emilien Macchi <emacchi@redhat.com>
Anerudhan
added a commit
that referenced
this pull request
Sep 4, 2025
## 🚀 Improvements
### 🔹 SDPA
- Improved support checks for **Hopper backward propagation (bprop)** to fix a bug (introduced in `9.11` and fixed in `9.13`) affecting certain large head-dimension combinations of *d_qk* and *d_v*.
- Added support for sink parameter for SDPA opertation. Refer new samples
- `fp16_fwd_with_sink_token.cpp`
- `fp16_bwd_with_sink_token.cpp`
### 🔹 Pointwise
- Added beta support for configurable beta for swish
### 🔹 Other Updates
- See PR #163 and #165 for custom DLPack path
✅ Recommended Action: Upgrade to cuDNN Frontend v1.14.1 for full compatibility with cuDNN 9.13.0+, improved SDPA support, additional normalization support, and deviceless graph compilation features.
Merged
Anerudhan
added a commit
that referenced
this pull request
Sep 5, 2025
## 🚀 Improvements
### 🔹 SDPA
- Improved support checks for **Hopper backward propagation (bprop)** to fix a bug (introduced in `9.11` and fixed in `9.13`) affecting certain large head-dimension combinations of *d_qk* and *d_v*.
- Added support for sink parameter for SDPA opertation. Refer new samples
- `fp16_fwd_with_sink_token.cpp`
- `fp16_bwd_with_sink_token.cpp`
### 🔹 Pointwise
- Added beta support for configurable beta for swish
### 🔹 Other Updates
- See PR #163 and #165 for custom DLPack path
✅ Recommended Action: Upgrade to cuDNN Frontend v1.14.1 for full compatibility with cuDNN 9.13.0+, improved SDPA support, additional normalization support, and deviceless graph compilation features.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create dlpack_version.txt file containing the required dlpack version
and update CMakeLists.txt to read from it instead of hardcoding the
version. This addresses issue #164 by making the dlpack dependency
version easily accessible to users and automated build systems
without requiring manual parsing of CMake files.
Fixes #164