This PR addresses to known security issues #13804
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ssofja <sofiakostandian@gmail.com>
Signed-off-by: Ssofja <Ssofja@users.noreply.github.com> Signed-off-by: Ssofja <sofiakostandian@gmail.com>
Signed-off-by: Ssofja <sofiakostandian@gmail.com>
Ssofja
force-pushed
the
joblib_security_fix
branch
from
4d7219c to
7e66238
Compare
Signed-off-by: artbataev <artbataev@users.noreply.github.com>
nithinraok
approved these changes
Jun 2, 2025
|
[🤖]: Hi @Ssofja 👋, We wanted to let you know that a CICD pipeline for this PR just finished successfully. So it might be time to merge this PR or get some approvals. |
|
@chtruong814 can we merge this? It was reverted before |
|
Thanks for fixing this. |
Ssofja
changed the title
ko3n1g
pushed a commit
that referenced
this pull request
Jun 22, 2025
* decompressing joblib file before checking it Signed-off-by: Ssofja <sofiakostandian@gmail.com> * Apply isort and black reformatting Signed-off-by: Ssofja <Ssofja@users.noreply.github.com> Signed-off-by: Ssofja <sofiakostandian@gmail.com> * Updated tests to create valid dummy files Signed-off-by: Ssofja <sofiakostandian@gmail.com> * Apply isort and black reformatting Signed-off-by: artbataev <artbataev@users.noreply.github.com> --------- Signed-off-by: Ssofja <sofiakostandian@gmail.com> Signed-off-by: Ssofja <Ssofja@users.noreply.github.com> Signed-off-by: artbataev <artbataev@users.noreply.github.com> Co-authored-by: Ssofja <Ssofja@users.noreply.github.com> Co-authored-by: artbataev <artbataev@users.noreply.github.com>
chtruong814
pushed a commit
that referenced
this pull request
Jun 28, 2025
* decompressing joblib file before checking it Signed-off-by: Ssofja <sofiakostandian@gmail.com> * Apply isort and black reformatting Signed-off-by: Ssofja <Ssofja@users.noreply.github.com> Signed-off-by: Ssofja <sofiakostandian@gmail.com> * Updated tests to create valid dummy files Signed-off-by: Ssofja <sofiakostandian@gmail.com> * Apply isort and black reformatting Signed-off-by: artbataev <artbataev@users.noreply.github.com> --------- Signed-off-by: Ssofja <sofiakostandian@gmail.com> Signed-off-by: Ssofja <Ssofja@users.noreply.github.com> Signed-off-by: artbataev <artbataev@users.noreply.github.com> Co-authored-by: Ssofja <Ssofja@users.noreply.github.com> Co-authored-by: artbataev <artbataev@users.noreply.github.com> Signed-off-by: Charlie Truong <chtruong@nvidia.com>
chtruong814
pushed a commit
that referenced
this pull request
Jun 29, 2025
* decompressing joblib file before checking it * Apply isort and black reformatting * Updated tests to create valid dummy files * Apply isort and black reformatting --------- Signed-off-by: Ssofja <sofiakostandian@gmail.com> Signed-off-by: Ssofja <Ssofja@users.noreply.github.com> Signed-off-by: artbataev <artbataev@users.noreply.github.com> Co-authored-by: Ssofja <78349198+Ssofja@users.noreply.github.com> Co-authored-by: Ssofja <Ssofja@users.noreply.github.com> Co-authored-by: artbataev <artbataev@users.noreply.github.com>
AmirHussein96
pushed a commit
to AmirHussein96/NeMo
that referenced
this pull request
Aug 5, 2025
* decompressing joblib file before checking it Signed-off-by: Ssofja <sofiakostandian@gmail.com> * Apply isort and black reformatting Signed-off-by: Ssofja <Ssofja@users.noreply.github.com> Signed-off-by: Ssofja <sofiakostandian@gmail.com> * Updated tests to create valid dummy files Signed-off-by: Ssofja <sofiakostandian@gmail.com> * Apply isort and black reformatting Signed-off-by: artbataev <artbataev@users.noreply.github.com> --------- Signed-off-by: Ssofja <sofiakostandian@gmail.com> Signed-off-by: Ssofja <Ssofja@users.noreply.github.com> Signed-off-by: artbataev <artbataev@users.noreply.github.com> Co-authored-by: Ssofja <Ssofja@users.noreply.github.com> Co-authored-by: artbataev <artbataev@users.noreply.github.com> Signed-off-by: Amir Hussein <amhussein@nvidia.com>
AmirHussein96
pushed a commit
to AmirHussein96/NeMo
that referenced
this pull request
Aug 5, 2025
* decompressing joblib file before checking it Signed-off-by: Ssofja <sofiakostandian@gmail.com> * Apply isort and black reformatting Signed-off-by: Ssofja <Ssofja@users.noreply.github.com> Signed-off-by: Ssofja <sofiakostandian@gmail.com> * Updated tests to create valid dummy files Signed-off-by: Ssofja <sofiakostandian@gmail.com> * Apply isort and black reformatting Signed-off-by: artbataev <artbataev@users.noreply.github.com> --------- Signed-off-by: Ssofja <sofiakostandian@gmail.com> Signed-off-by: Ssofja <Ssofja@users.noreply.github.com> Signed-off-by: artbataev <artbataev@users.noreply.github.com> Co-authored-by: Ssofja <Ssofja@users.noreply.github.com> Co-authored-by: artbataev <artbataev@users.noreply.github.com> Signed-off-by: Amir Hussein <amhussein@nvidia.com>
nasretdinovr
pushed a commit
to nasretdinovr/NeMo
that referenced
this pull request
Aug 8, 2025
* decompressing joblib file before checking it Signed-off-by: Ssofja <sofiakostandian@gmail.com> * Apply isort and black reformatting Signed-off-by: Ssofja <Ssofja@users.noreply.github.com> Signed-off-by: Ssofja <sofiakostandian@gmail.com> * Updated tests to create valid dummy files Signed-off-by: Ssofja <sofiakostandian@gmail.com> * Apply isort and black reformatting Signed-off-by: artbataev <artbataev@users.noreply.github.com> --------- Signed-off-by: Ssofja <sofiakostandian@gmail.com> Signed-off-by: Ssofja <Ssofja@users.noreply.github.com> Signed-off-by: artbataev <artbataev@users.noreply.github.com> Co-authored-by: Ssofja <Ssofja@users.noreply.github.com> Co-authored-by: artbataev <artbataev@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
The
Update branchbutton must only be pressed in very rare occassions.An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.
What does this PR do ?
This PR addresses known security issues. For the latest NVIDIA Vulnerability Disclosure Information visit https://www.nvidia.com/en-us/security/, for acknowledgement please reach out to the NVIDIA PSIRT team at PSIRT@nvidia.com
Collection: [Note which collection this PR will affect]
PR Type: