Sketch dist-ckpt content versioning #13839
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikolajblaz
commented
Jun 9, 2025
|
|
||
| To accelerate checkpoint saving, it is recommended to set ``dist_ckpt_assume_constant_structure=True``. | ||
|
|
||
| **9. Q: I get an error about an "invalid access pattern". What does it mean?** |
There was a problem hiding this comment.
A bonus unrelated to the MR :)
mikolajblaz
force-pushed
the
mblaz/dist-ckpt-content-versioning
branch
from
a35348c to
df69593
Compare
Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com> # Conflicts: # nemo/lightning/pytorch/strategies/megatron_strategy.py
Signed-off-by: mikolajblaz <mikolajblaz@users.noreply.github.com> Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com>
Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com>
Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com>
Signed-off-by: mikolajblaz <mikolajblaz@users.noreply.github.com> Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com>
Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com>
Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com>
Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com>
Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com>
Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com>
Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com>
Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com>
Signed-off-by: mikolajblaz <mikolajblaz@users.noreply.github.com> Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com>
mikolajblaz
force-pushed
the
mblaz/dist-ckpt-content-versioning
branch
from
df69593 to
05ceba1
Compare
Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com>
Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com>
mikolajblaz
force-pushed
the
mblaz/dist-ckpt-content-versioning
branch
from
518afd7 to
1cc6744
Compare
Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| try: | ||
| scaler.update() | ||
| except AssertionError: |
Check notice
Code scanning / CodeQL
Empty except Note test
Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com>
mikolajblaz
force-pushed
the
mblaz/dist-ckpt-content-versioning
branch
from
bfb19ca to
77742bb
Compare
ananthsub
approved these changes
Aug 13, 2025
guyueh1
pushed a commit
to guyueh1/NeMo
that referenced
this pull request
Aug 25, 2025
* Sketch dist-ckpt content versioning Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com> # Conflicts: # nemo/lightning/pytorch/strategies/megatron_strategy.py * Apply isort and black reformatting Signed-off-by: mikolajblaz <mikolajblaz@users.noreply.github.com> Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com> * Add docs Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com> * Change dist_opt_sharding_type name Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com> * Remove MappingProxyType Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com> * Apply isort and black reformatting Signed-off-by: mikolajblaz <mikolajblaz@users.noreply.github.com> Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com> * Expand docs Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com> * Fix .rst formatting Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com> * Fix .rst formatting Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com> * Fix .rst formatting Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com> * Fix .rst formatting Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com> * Unindent code Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com> * Match MLM metadata creation logic Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com> * Apply isort and black reformatting Signed-off-by: mikolajblaz <mikolajblaz@users.noreply.github.com> Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com> * Remove one Nemo1 TODO Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com> * Add doc Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com> * Remove collections/nlp TODOs (NeMo 1) Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com> * Fix some TODOs Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com> * Remove f string Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com> * Fix MegatronStrategy typo Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com> * Handle TODOs Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com> * Add missing import Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com> * Add content metadata flag to async Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com> * Add missing load_content_metadata Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com> * Load content_metadata through unwrapped_ckpt_io Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com> * Pass content_metadata through storage_options Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com> * Fix linting problems Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com> * Add sharded_state_dict_metadata to FabricMegatronStrategy Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com> * Fix indentation Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com> * Fix last unwrapped_checkpoint_io Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com> * Fix None type Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com> * Add local ckpt versioning note Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com> * Add safe_import fix Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com> * Revert nemo_logger changes Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com> * Remove chained_optim_avoid_prefix flag Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com> * add unit tests Signed-off-by: dimapihtar <dpihtar@gmail.com> * Apply isort and black reformatting Signed-off-by: dimapihtar <dimapihtar@users.noreply.github.com> * Fix OptimizerWrapper init signature Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com> --------- Signed-off-by: mikolajblaz <mikolajblaz@users.noreply.github.com> Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com> Signed-off-by: dimapihtar <dpihtar@gmail.com> Signed-off-by: dimapihtar <dimapihtar@users.noreply.github.com> Co-authored-by: Charlie Truong <chtruong@nvidia.com> Co-authored-by: dimapihtar <dpihtar@gmail.com> Co-authored-by: dimapihtar <dimapihtar@users.noreply.github.com> Co-authored-by: Dmytro Pykhtar <37850217+dimapihtar@users.noreply.github.com> Signed-off-by: Guyue Huang <guyueh@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
The
Update branchbutton must only be pressed in very rare occassions.An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.
What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use thisGitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information