Add Nemotron-H prompt format, fix cut-to-conversation custom attr propagation #13963
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Piotr Żelasko <petezor@gmail.com>
Signed-off-by: Piotr Żelasko <petezor@gmail.com>
pzelasko
changed the title
Signed-off-by: Piotr Żelasko <petezor@gmail.com>
|
[🤖]: Hi @pzelasko 👋, We wanted to let you know that a CICD pipeline for this PR just finished successfully. So it might be time to merge this PR or get some approvals. |
zhehuaichen
approved these changes
Jun 27, 2025
| assert canary_tokenizer.ids_to_text(ans["context_ids"].tolist()) == '<|startoftranscript|><|en|><|transcribe|><|en|><|pnc|>' | ||
| assert canary_tokenizer.ids_to_text(ans["answer_ids"].tolist()) == ' TEST<|endoftext|>' | ||
| assert ans["mask"].tolist() == [False] * 5 + [True] * 5 | ||
| assert ans["mask"].shape[0] == ans["input_ids"].shape[0] |
There was a problem hiding this comment.
why do we need to update this? same question for other tests
There was a problem hiding this comment.
just to simplify editing the unit tests; technically I think this specific assertion may even be removed as there is a separate test for the masking logic in prompt formatter
Some changes in how SALM accesses various modules and properties of |
AmirHussein96
pushed a commit
to AmirHussein96/NeMo
that referenced
this pull request
Jul 23, 2025
…pagation (NVIDIA-NeMo#13963) * Add Nemotron-H prompt format Signed-off-by: Piotr Żelasko <petezor@gmail.com> * Fix propagation of custom attr in cut_to_conversation Signed-off-by: Piotr Żelasko <petezor@gmail.com> * Fix CI Signed-off-by: Piotr Żelasko <petezor@gmail.com> * Unit test for the conversion fix Signed-off-by: Piotr Żelasko <petezor@gmail.com> --------- Signed-off-by: Piotr Żelasko <petezor@gmail.com> Co-authored-by: Charlie Truong <chtruong@nvidia.com> Signed-off-by: Amir Hussein <amhussein@nvidia.com>
AmirHussein96
pushed a commit
to AmirHussein96/NeMo
that referenced
this pull request
Aug 5, 2025
…pagation (NVIDIA-NeMo#13963) * Add Nemotron-H prompt format Signed-off-by: Piotr Żelasko <petezor@gmail.com> * Fix propagation of custom attr in cut_to_conversation Signed-off-by: Piotr Żelasko <petezor@gmail.com> * Fix CI Signed-off-by: Piotr Żelasko <petezor@gmail.com> * Unit test for the conversion fix Signed-off-by: Piotr Żelasko <petezor@gmail.com> --------- Signed-off-by: Piotr Żelasko <petezor@gmail.com> Co-authored-by: Charlie Truong <chtruong@nvidia.com> Signed-off-by: Amir Hussein <amhussein@nvidia.com>
AmirHussein96
pushed a commit
to AmirHussein96/NeMo
that referenced
this pull request
Aug 5, 2025
…pagation (NVIDIA-NeMo#13963) * Add Nemotron-H prompt format Signed-off-by: Piotr Żelasko <petezor@gmail.com> * Fix propagation of custom attr in cut_to_conversation Signed-off-by: Piotr Żelasko <petezor@gmail.com> * Fix CI Signed-off-by: Piotr Żelasko <petezor@gmail.com> * Unit test for the conversion fix Signed-off-by: Piotr Żelasko <petezor@gmail.com> --------- Signed-off-by: Piotr Żelasko <petezor@gmail.com> Co-authored-by: Charlie Truong <chtruong@nvidia.com> Signed-off-by: Amir Hussein <amhussein@nvidia.com>
nasretdinovr
pushed a commit
to nasretdinovr/NeMo
that referenced
this pull request
Aug 8, 2025
…pagation (NVIDIA-NeMo#13963) * Add Nemotron-H prompt format Signed-off-by: Piotr Żelasko <petezor@gmail.com> * Fix propagation of custom attr in cut_to_conversation Signed-off-by: Piotr Żelasko <petezor@gmail.com> * Fix CI Signed-off-by: Piotr Żelasko <petezor@gmail.com> * Unit test for the conversion fix Signed-off-by: Piotr Żelasko <petezor@gmail.com> --------- Signed-off-by: Piotr Żelasko <petezor@gmail.com> Co-authored-by: Charlie Truong <chtruong@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
The
Update branchbutton must only be pressed in very rare occassions.An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.
What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use thisGitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information