-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Higher-level API for SALM.generate #14034
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Piotr Żelasko <petezor@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
|
@pzelasko I think that failing test is unrelated. If you're good with my merging this, I can merge this for you. |
@chtruong814 That would be great - thank you! |
* Higher-level API for SALM.generate Signed-off-by: Piotr Żelasko <petezor@gmail.com> * fix Signed-off-by: Piotr Żelasko <petezor@gmail.com> --------- Signed-off-by: Piotr Żelasko <petezor@gmail.com> Signed-off-by: Amir Hussein <amhussein@nvidia.com>
* Higher-level API for SALM.generate Signed-off-by: Piotr Żelasko <petezor@gmail.com> * fix Signed-off-by: Piotr Żelasko <petezor@gmail.com> --------- Signed-off-by: Piotr Żelasko <petezor@gmail.com> Signed-off-by: Amir Hussein <amhussein@nvidia.com>
* Higher-level API for SALM.generate Signed-off-by: Piotr Żelasko <petezor@gmail.com> * fix Signed-off-by: Piotr Żelasko <petezor@gmail.com> --------- Signed-off-by: Piotr Żelasko <petezor@gmail.com> Signed-off-by: Amir Hussein <amhussein@nvidia.com>
* Higher-level API for SALM.generate Signed-off-by: Piotr Żelasko <petezor@gmail.com> * fix Signed-off-by: Piotr Żelasko <petezor@gmail.com> --------- Signed-off-by: Piotr Żelasko <petezor@gmail.com>
What does this PR do ?
Enable the following, simpler, usage pattern for inference:
Collection: speechlm2
Changelog
audiokey inpromptslist (can be a string or a list if multiple audio locator tags are used)generation_kwargsto be passed directly tomodel.llm.generateused under the hood.generation_configis not specified, we'll auto-create one, pre-populating BOS, EOS, and PAD token ids.Usage
# Add a code snippet demonstrating how to use thisGitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information