remove QA collection #14092
Merged
remove QA collection #14092
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dimapihtar <dpihtar@gmail.com>
Signed-off-by: dimapihtar <dpihtar@gmail.com>
Signed-off-by: dimapihtar <dimapihtar@users.noreply.github.com>
Signed-off-by: dimapihtar <dpihtar@gmail.com>
…nto dpykhtar/remove_qa
Signed-off-by: dimapihtar <dpihtar@gmail.com>
Signed-off-by: dimapihtar <dimapihtar@users.noreply.github.com>
…nto dpykhtar/remove_qa
Signed-off-by: dimapihtar <dimapihtar@users.noreply.github.com>
Signed-off-by: dimapihtar <dpihtar@gmail.com>
…nto dpykhtar/remove_qa Signed-off-by: dimapihtar <dpihtar@gmail.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| from nemo.collections.nlp.data.data_utils import * | ||
| from nemo.collections.nlp.data.entity_linking.entity_linking_dataset import EntityLinkingDataset | ||
| from nemo.collections.nlp.data.information_retrieval.information_retrieval_dataset import ( | ||
| from nemo.collections.nlp.data.data_utils import * # noqa: F401 |
Check notice
Code scanning / CodeQL
'import *' may pollute namespace Note
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 4 months ago
To fix the issue, replace the from nemo.collections.nlp.data.data_utils import * statement with explicit imports of the specific names that are actually used from the data_utils module. This ensures that only the required names are imported, avoiding namespace pollution and improving code readability.
Steps to implement the fix:
- Identify the specific names used from the
data_utilsmodule in the current file or elsewhere in the project. - Replace the
import *statement with explicit imports of those names. - Ensure that the functionality remains unchanged by verifying that all required names are correctly imported.
Suggested changeset
1
nemo/collections/nlp/data/__init__.py
| @@ -14,3 +14,7 @@ | ||
|
|
||
| from nemo.collections.nlp.data.data_utils import * # noqa: F401 | ||
| from nemo.collections.nlp.data.data_utils import ( # noqa: F401 | ||
| function_name_1, | ||
| function_name_2, | ||
| class_name_1, | ||
| ) | ||
| from nemo.collections.nlp.data.entity_linking.entity_linking_dataset import EntityLinkingDataset # noqa: F401 |
Copilot is powered by AI and may make mistakes. Always verify output.
|
[🤖]: Hi @dimapihtar 👋, We wanted to let you know that a CICD pipeline for this PR just finished successfully. So it might be time to merge this PR or get some approvals. |
Signed-off-by: Dmytro Pykhtar <37850217+dimapihtar@users.noreply.github.com>
Signed-off-by: dimapihtar <dpihtar@gmail.com>
|
[🤖]: Hi @dimapihtar 👋, We wanted to let you know that a CICD pipeline for this PR just finished successfully. So it might be time to merge this PR or get some approvals. |
yaoyu-33
approved these changes
Jul 3, 2025
AmirHussein96
pushed a commit
to AmirHussein96/NeMo
that referenced
this pull request
Jul 23, 2025
* remove QA collection Signed-off-by: dimapihtar <dpihtar@gmail.com> * fix imports Signed-off-by: dimapihtar <dpihtar@gmail.com> * Apply isort and black reformatting Signed-off-by: dimapihtar <dimapihtar@users.noreply.github.com> * fix imports Signed-off-by: dimapihtar <dpihtar@gmail.com> * fix imports Signed-off-by: dimapihtar <dpihtar@gmail.com> * Apply isort and black reformatting Signed-off-by: dimapihtar <dimapihtar@users.noreply.github.com> * Apply isort and black reformatting Signed-off-by: dimapihtar <dimapihtar@users.noreply.github.com> * fix imports Signed-off-by: dimapihtar <dpihtar@gmail.com> * remove QA examples Signed-off-by: dimapihtar <dpihtar@gmail.com> --------- Signed-off-by: dimapihtar <dpihtar@gmail.com> Signed-off-by: dimapihtar <dimapihtar@users.noreply.github.com> Signed-off-by: Dmytro Pykhtar <37850217+dimapihtar@users.noreply.github.com> Co-authored-by: dimapihtar <dimapihtar@users.noreply.github.com> Signed-off-by: Amir Hussein <amhussein@nvidia.com>
AmirHussein96
pushed a commit
to AmirHussein96/NeMo
that referenced
this pull request
Aug 5, 2025
* remove QA collection Signed-off-by: dimapihtar <dpihtar@gmail.com> * fix imports Signed-off-by: dimapihtar <dpihtar@gmail.com> * Apply isort and black reformatting Signed-off-by: dimapihtar <dimapihtar@users.noreply.github.com> * fix imports Signed-off-by: dimapihtar <dpihtar@gmail.com> * fix imports Signed-off-by: dimapihtar <dpihtar@gmail.com> * Apply isort and black reformatting Signed-off-by: dimapihtar <dimapihtar@users.noreply.github.com> * Apply isort and black reformatting Signed-off-by: dimapihtar <dimapihtar@users.noreply.github.com> * fix imports Signed-off-by: dimapihtar <dpihtar@gmail.com> * remove QA examples Signed-off-by: dimapihtar <dpihtar@gmail.com> --------- Signed-off-by: dimapihtar <dpihtar@gmail.com> Signed-off-by: dimapihtar <dimapihtar@users.noreply.github.com> Signed-off-by: Dmytro Pykhtar <37850217+dimapihtar@users.noreply.github.com> Co-authored-by: dimapihtar <dimapihtar@users.noreply.github.com> Signed-off-by: Amir Hussein <amhussein@nvidia.com>
AmirHussein96
pushed a commit
to AmirHussein96/NeMo
that referenced
this pull request
Aug 5, 2025
* remove QA collection Signed-off-by: dimapihtar <dpihtar@gmail.com> * fix imports Signed-off-by: dimapihtar <dpihtar@gmail.com> * Apply isort and black reformatting Signed-off-by: dimapihtar <dimapihtar@users.noreply.github.com> * fix imports Signed-off-by: dimapihtar <dpihtar@gmail.com> * fix imports Signed-off-by: dimapihtar <dpihtar@gmail.com> * Apply isort and black reformatting Signed-off-by: dimapihtar <dimapihtar@users.noreply.github.com> * Apply isort and black reformatting Signed-off-by: dimapihtar <dimapihtar@users.noreply.github.com> * fix imports Signed-off-by: dimapihtar <dpihtar@gmail.com> * remove QA examples Signed-off-by: dimapihtar <dpihtar@gmail.com> --------- Signed-off-by: dimapihtar <dpihtar@gmail.com> Signed-off-by: dimapihtar <dimapihtar@users.noreply.github.com> Signed-off-by: Dmytro Pykhtar <37850217+dimapihtar@users.noreply.github.com> Co-authored-by: dimapihtar <dimapihtar@users.noreply.github.com> Signed-off-by: Amir Hussein <amhussein@nvidia.com>
nasretdinovr
pushed a commit
to nasretdinovr/NeMo
that referenced
this pull request
Aug 8, 2025
* remove QA collection Signed-off-by: dimapihtar <dpihtar@gmail.com> * fix imports Signed-off-by: dimapihtar <dpihtar@gmail.com> * Apply isort and black reformatting Signed-off-by: dimapihtar <dimapihtar@users.noreply.github.com> * fix imports Signed-off-by: dimapihtar <dpihtar@gmail.com> * fix imports Signed-off-by: dimapihtar <dpihtar@gmail.com> * Apply isort and black reformatting Signed-off-by: dimapihtar <dimapihtar@users.noreply.github.com> * Apply isort and black reformatting Signed-off-by: dimapihtar <dimapihtar@users.noreply.github.com> * fix imports Signed-off-by: dimapihtar <dpihtar@gmail.com> * remove QA examples Signed-off-by: dimapihtar <dpihtar@gmail.com> --------- Signed-off-by: dimapihtar <dpihtar@gmail.com> Signed-off-by: dimapihtar <dimapihtar@users.noreply.github.com> Signed-off-by: Dmytro Pykhtar <37850217+dimapihtar@users.noreply.github.com> Co-authored-by: dimapihtar <dimapihtar@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
The
Update branchbutton must only be pressed in very rare occassions.An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.
What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use thisGitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information