remove text nlp collection #14110

dimapihtar · 2025-07-02T10:51:01Z

Important

The Update branch button must only be pressed in very rare occassions.
An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.

What does this PR do ?

Removes next parts of nlp collection (with their examples): text_normalization_as_tagging , text_classification, text2sparql, spellchecking_asr_customization, duplex_text_normalization.

Collection: [Note which collection this PR will affect]

Changelog

Add specific line by line info of high level changes in this PR.

Usage

You can potentially add a usage example below

# Add a code snippet demonstrating how to use this

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

Make sure you read and followed Contributor guidelines
Did you write any new necessary tests?
Did you add or update any necessary documentation?
Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

New Feature
Bugfix
Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

Related to # (issue)

Signed-off-by: dimapihtar <dpihtar@gmail.com>

Signed-off-by: dimapihtar <dimapihtar@users.noreply.github.com>

Signed-off-by: dimapihtar <dpihtar@gmail.com>

…NeMo into dpykhtar/remove_text_nlp Signed-off-by: dimapihtar <dpihtar@gmail.com>

Signed-off-by: dimapihtar <dimapihtar@users.noreply.github.com>

nemo/collections/nlp/data/__init__.py

-from nemo.collections.nlp.data.data_utils import *
-from nemo.collections.nlp.data.entity_linking.entity_linking_dataset import EntityLinkingDataset
-from nemo.collections.nlp.data.information_retrieval.information_retrieval_dataset import (
+from nemo.collections.nlp.data.data_utils import *  # noqa: F401


To fix the issue, replace the from nemo.collections.nlp.data.data_utils import * statement with explicit imports of the specific names required from the data_utils module. This ensures that only the necessary names are imported, avoiding namespace pollution.

Steps:

Identify the specific names used from the data_utils module in the current file or elsewhere in the codebase.

Replace the import * statement with explicit imports of those names.

Signed-off-by: dimapihtar <dpihtar@gmail.com>

…NeMo into dpykhtar/remove_text_nlp

Signed-off-by: dimapihtar <dpihtar@gmail.com>

Signed-off-by: dimapihtar <dimapihtar@users.noreply.github.com>

Signed-off-by: dimapihtar <dpihtar@gmail.com>

…NeMo into dpykhtar/remove_text_nlp

Signed-off-by: dimapihtar <dpihtar@gmail.com>

Signed-off-by: dimapihtar <dimapihtar@users.noreply.github.com>

Signed-off-by: dimapihtar <dpihtar@gmail.com>

…NeMo into dpykhtar/remove_text_nlp

Signed-off-by: dimapihtar <dpihtar@gmail.com>

Signed-off-by: dimapihtar <dimapihtar@users.noreply.github.com>

github-actions · 2025-07-02T22:05:39Z

[🤖]: Hi @dimapihtar 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully.

So it might be time to merge this PR or get some approvals.

//cc @chtruong814 @ko3n1g @pablo-garay @thomasdhc

Signed-off-by: dimapihtar <dpihtar@gmail.com>

Signed-off-by: Dmytro Pykhtar <37850217+dimapihtar@users.noreply.github.com>

github-actions · 2025-07-05T02:16:57Z

[🤖]: Hi @dimapihtar 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully.

So it might be time to merge this PR or get some approvals.

//cc @chtruong814 @ko3n1g @pablo-garay @thomasdhc

* remove text nlp collection Signed-off-by: dimapihtar <dpihtar@gmail.com> * Apply isort and black reformatting Signed-off-by: dimapihtar <dimapihtar@users.noreply.github.com> * fix style Signed-off-by: dimapihtar <dpihtar@gmail.com> * Apply isort and black reformatting Signed-off-by: dimapihtar <dimapihtar@users.noreply.github.com> * remove duplex_text Signed-off-by: dimapihtar <dpihtar@gmail.com> * fix imports Signed-off-by: dimapihtar <dpihtar@gmail.com> * Apply isort and black reformatting Signed-off-by: dimapihtar <dimapihtar@users.noreply.github.com> * remove spellchecking Signed-off-by: dimapihtar <dpihtar@gmail.com> * fix import Signed-off-by: dimapihtar <dpihtar@gmail.com> * Apply isort and black reformatting Signed-off-by: dimapihtar <dimapihtar@users.noreply.github.com> * fix style Signed-off-by: dimapihtar <dpihtar@gmail.com> * fix import Signed-off-by: dimapihtar <dpihtar@gmail.com> * Apply isort and black reformatting Signed-off-by: dimapihtar <dimapihtar@users.noreply.github.com> * remove examples Signed-off-by: dimapihtar <dpihtar@gmail.com> --------- Signed-off-by: dimapihtar <dpihtar@gmail.com> Signed-off-by: dimapihtar <dimapihtar@users.noreply.github.com> Signed-off-by: Dmytro Pykhtar <37850217+dimapihtar@users.noreply.github.com> Co-authored-by: dimapihtar <dimapihtar@users.noreply.github.com> Signed-off-by: Amir Hussein <amhussein@nvidia.com>

* remove text nlp collection Signed-off-by: dimapihtar <dpihtar@gmail.com> * Apply isort and black reformatting Signed-off-by: dimapihtar <dimapihtar@users.noreply.github.com> * fix style Signed-off-by: dimapihtar <dpihtar@gmail.com> * Apply isort and black reformatting Signed-off-by: dimapihtar <dimapihtar@users.noreply.github.com> * remove duplex_text Signed-off-by: dimapihtar <dpihtar@gmail.com> * fix imports Signed-off-by: dimapihtar <dpihtar@gmail.com> * Apply isort and black reformatting Signed-off-by: dimapihtar <dimapihtar@users.noreply.github.com> * remove spellchecking Signed-off-by: dimapihtar <dpihtar@gmail.com> * fix import Signed-off-by: dimapihtar <dpihtar@gmail.com> * Apply isort and black reformatting Signed-off-by: dimapihtar <dimapihtar@users.noreply.github.com> * fix style Signed-off-by: dimapihtar <dpihtar@gmail.com> * fix import Signed-off-by: dimapihtar <dpihtar@gmail.com> * Apply isort and black reformatting Signed-off-by: dimapihtar <dimapihtar@users.noreply.github.com> * remove examples Signed-off-by: dimapihtar <dpihtar@gmail.com> --------- Signed-off-by: dimapihtar <dpihtar@gmail.com> Signed-off-by: dimapihtar <dimapihtar@users.noreply.github.com> Signed-off-by: Dmytro Pykhtar <37850217+dimapihtar@users.noreply.github.com> Co-authored-by: dimapihtar <dimapihtar@users.noreply.github.com>

* remove text nlp collection Signed-off-by: dimapihtar <dpihtar@gmail.com> * Apply isort and black reformatting Signed-off-by: dimapihtar <dimapihtar@users.noreply.github.com> * fix style Signed-off-by: dimapihtar <dpihtar@gmail.com> * Apply isort and black reformatting Signed-off-by: dimapihtar <dimapihtar@users.noreply.github.com> * remove duplex_text Signed-off-by: dimapihtar <dpihtar@gmail.com> * fix imports Signed-off-by: dimapihtar <dpihtar@gmail.com> * Apply isort and black reformatting Signed-off-by: dimapihtar <dimapihtar@users.noreply.github.com> * remove spellchecking Signed-off-by: dimapihtar <dpihtar@gmail.com> * fix import Signed-off-by: dimapihtar <dpihtar@gmail.com> * Apply isort and black reformatting Signed-off-by: dimapihtar <dimapihtar@users.noreply.github.com> * fix style Signed-off-by: dimapihtar <dpihtar@gmail.com> * fix import Signed-off-by: dimapihtar <dpihtar@gmail.com> * Apply isort and black reformatting Signed-off-by: dimapihtar <dimapihtar@users.noreply.github.com> * remove examples Signed-off-by: dimapihtar <dpihtar@gmail.com> --------- Signed-off-by: dimapihtar <dpihtar@gmail.com> Signed-off-by: dimapihtar <dimapihtar@users.noreply.github.com> Signed-off-by: Dmytro Pykhtar <37850217+dimapihtar@users.noreply.github.com> Co-authored-by: dimapihtar <dimapihtar@users.noreply.github.com> Signed-off-by: Guyue Huang <guyueh@nvidia.com>

remove text nlp collection

699a295

Signed-off-by: dimapihtar <dpihtar@gmail.com>

github-actions bot added the NLP label Jul 2, 2025

dimapihtar and others added 4 commits July 2, 2025 10:51

Apply isort and black reformatting

11480f0

Signed-off-by: dimapihtar <dimapihtar@users.noreply.github.com>

fix style

ae4d5a2

Signed-off-by: dimapihtar <dpihtar@gmail.com>

Merge branch 'dpykhtar/remove_text_nlp' of https://github.com/NVIDIA/…

4c3fca6

…NeMo into dpykhtar/remove_text_nlp Signed-off-by: dimapihtar <dpihtar@gmail.com>

Apply isort and black reformatting

5ead5f0

Signed-off-by: dimapihtar <dimapihtar@users.noreply.github.com>

github-advanced-security bot found potential problems Jul 2, 2025

View reviewed changes

dimapihtar and others added 12 commits July 2, 2025 04:20

remove duplex_text

b68cea2

Signed-off-by: dimapihtar <dpihtar@gmail.com>

Merge branch 'dpykhtar/remove_text_nlp' of https://github.com/NVIDIA/…

5202022

…NeMo into dpykhtar/remove_text_nlp

fix imports

ffd2be1

Signed-off-by: dimapihtar <dpihtar@gmail.com>

Apply isort and black reformatting

d1b5408

Signed-off-by: dimapihtar <dimapihtar@users.noreply.github.com>

remove spellchecking

e1a16a2

Signed-off-by: dimapihtar <dpihtar@gmail.com>

Merge branch 'dpykhtar/remove_text_nlp' of https://github.com/NVIDIA/…

c2093d7

…NeMo into dpykhtar/remove_text_nlp

fix import

c0bb44b

Signed-off-by: dimapihtar <dpihtar@gmail.com>

Apply isort and black reformatting

67b9f5e

Signed-off-by: dimapihtar <dimapihtar@users.noreply.github.com>

fix style

e79e6e7

Signed-off-by: dimapihtar <dpihtar@gmail.com>

Merge branch 'dpykhtar/remove_text_nlp' of https://github.com/NVIDIA/…

e79b6b8

…NeMo into dpykhtar/remove_text_nlp

fix import

60454c2

Signed-off-by: dimapihtar <dpihtar@gmail.com>

Apply isort and black reformatting

cd7a873

Signed-off-by: dimapihtar <dimapihtar@users.noreply.github.com>

dimapihtar requested a review from yaoyu-33 July 2, 2025 12:29

dimapihtar added the Run CICD label Jul 2, 2025

dimapihtar temporarily deployed to test July 2, 2025 12:30 — with GitHub Actions Inactive

github-actions bot removed the Run CICD label Jul 2, 2025

dimapihtar and others added 2 commits July 3, 2025 04:40

remove examples

82278db

Signed-off-by: dimapihtar <dpihtar@gmail.com>

Merge branch 'main' into dpykhtar/remove_text_nlp

4d77a03

dimapihtar added the Run CICD label Jul 3, 2025

dimapihtar temporarily deployed to test July 3, 2025 11:51 — with GitHub Actions Inactive

yaoyu-33 previously approved these changes Jul 3, 2025

View reviewed changes

Merge branch 'main' into dpykhtar/remove_text_nlp

fbd3b71

Signed-off-by: Dmytro Pykhtar <37850217+dimapihtar@users.noreply.github.com>

dimapihtar dismissed yaoyu-33’s stale review via fbd3b71 July 3, 2025 17:46

ko3n1g added Run CICD and removed Run CICD labels Jul 3, 2025

ko3n1g temporarily deployed to test July 3, 2025 17:48 — with GitHub Actions Inactive

github-actions bot removed the Run CICD label Jul 5, 2025

dimapihtar requested a review from yaoyu-33 July 6, 2025 12:18

yaoyu-33 approved these changes Jul 8, 2025

View reviewed changes

dimapihtar merged commit c67474d into main Jul 8, 2025
197 checks passed

dimapihtar deleted the dpykhtar/remove_text_nlp branch July 8, 2025 16:40

@@ -14,3 +14,8 @@
-            from nemo.collections.nlp.data.data_utils import *  # noqa: F401
+            from nemo.collections.nlp.data.data_utils import (  # noqa: F401
+                function_name_1,
+                function_name_2,
+                class_name_1,
+                class_name_2,
+            )
             from nemo.collections.nlp.data.entity_linking.entity_linking_dataset import EntityLinkingDataset  # noqa: F401

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

remove text nlp collection #14110

remove text nlp collection #14110

Uh oh!

dimapihtar commented Jul 2, 2025 •

edited

Loading

Uh oh!

Check notice

Copilot Autofix

github-actions bot commented Jul 2, 2025

Uh oh!

github-actions bot commented Jul 5, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

remove text nlp collection #14110

remove text nlp collection #14110

Uh oh!

Conversation

dimapihtar commented Jul 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do ?

Changelog

Usage

GitHub Actions CI

Before your PR is "Ready for review"

Who can review?

Additional Information

Uh oh!

Check notice

Uh oh!

Copilot Autofix

github-actions bot commented Jul 2, 2025

Uh oh!

github-actions bot commented Jul 5, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

dimapihtar commented Jul 2, 2025 •

edited

Loading