fix QA comments NVBug #14196

huvunvidia · 2025-07-11T05:01:13Z

Important

The Update branch button must only be pressed in very rare occassions.
An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Collection: [Note which collection this PR will affect]

Changelog

Add specific line by line info of high level changes in this PR.

Usage

You can potentially add a usage example below

# Add a code snippet demonstrating how to use this

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

Make sure you read and followed Contributor guidelines
Did you write any new necessary tests?
Did you add or update any necessary documentation?
Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

New Feature
Bugfix
Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

Related to # (issue)

Signed-off-by: huvunvidia <huvunvidia@users.noreply.github.com>

github-actions · 2025-07-11T05:04:12Z

[🤖]: Hi @huvunvidia 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully.

So it might be time to merge this PR or get some approvals.

//cc @chtruong814 @ko3n1g @pablo-garay @thomasdhc

scripts/avlm/avlm_generate.py

scripts/avlm/avlm_nemo_run.py

Signed-off-by: Huy Vu <86480512+huvunvidia@users.noreply.github.com>

scripts/avlm/avlm_nemo_run.py

Signed-off-by: Huy Vu <86480512+huvunvidia@users.noreply.github.com>

github-actions · 2025-07-11T15:47:03Z

[🤖]: Hi @huvunvidia 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully.

So it might be time to merge this PR or get some approvals.

//cc @chtruong814 @ko3n1g @pablo-garay @thomasdhc

yashaswikarnati · 2025-07-11T16:07:55Z

nemo/collections/avlm/__init__.py

 from nemo.collections.avlm.data import AVLMMockDataModule
 from nemo.collections.avlm.model.avlm import AVLMConfig8B
 from nemo.collections.avlm.model.base import AVLMConfig, AVLMModel
+from nemo.collections.avlm.recipes import *


nit; to avoid circular imports in future, good to import what we need insted of *

yashaswikarnati · 2025-07-11T16:08:58Z

scripts/avlm/avlm_nemo_run.py

+
+    # run nemo_run
+    freeze_modules = {
+        "freeze_language_model": not args.unfreeze_language_model,


nit; may be the args can be directly args.freeze_vision_model etc.

* fix QA comments NVBug: NVBug link: https://nvbugspro.nvidia.com/bug/5381026 * Apply isort and black reformatting Signed-off-by: huvunvidia <huvunvidia@users.noreply.github.com> * Update avlm_generate.py Signed-off-by: Huy Vu <86480512+huvunvidia@users.noreply.github.com> * Update avlm_nemo_run.py Signed-off-by: Huy Vu <86480512+huvunvidia@users.noreply.github.com> * Update avlm_nemo_run.py Signed-off-by: Huy Vu <86480512+huvunvidia@users.noreply.github.com> --------- Signed-off-by: huvunvidia <huvunvidia@users.noreply.github.com> Signed-off-by: Huy Vu <86480512+huvunvidia@users.noreply.github.com> Co-authored-by: Huy Vu2 <huvu@login-eos01.eos.clusters.nvidia.com> Co-authored-by: huvunvidia <huvunvidia@users.noreply.github.com> Signed-off-by: Amir Hussein <amhussein@nvidia.com>

* fix QA comments NVBug: NVBug link: https://nvbugspro.nvidia.com/bug/5381026 * Apply isort and black reformatting Signed-off-by: huvunvidia <huvunvidia@users.noreply.github.com> * Update avlm_generate.py Signed-off-by: Huy Vu <86480512+huvunvidia@users.noreply.github.com> * Update avlm_nemo_run.py Signed-off-by: Huy Vu <86480512+huvunvidia@users.noreply.github.com> * Update avlm_nemo_run.py Signed-off-by: Huy Vu <86480512+huvunvidia@users.noreply.github.com> --------- Signed-off-by: huvunvidia <huvunvidia@users.noreply.github.com> Signed-off-by: Huy Vu <86480512+huvunvidia@users.noreply.github.com> Co-authored-by: Huy Vu2 <huvu@login-eos01.eos.clusters.nvidia.com> Co-authored-by: huvunvidia <huvunvidia@users.noreply.github.com>

* fix QA comments NVBug: NVBug link: https://nvbugspro.nvidia.com/bug/5381026 * Apply isort and black reformatting Signed-off-by: huvunvidia <huvunvidia@users.noreply.github.com> * Update avlm_generate.py Signed-off-by: Huy Vu <86480512+huvunvidia@users.noreply.github.com> * Update avlm_nemo_run.py Signed-off-by: Huy Vu <86480512+huvunvidia@users.noreply.github.com> * Update avlm_nemo_run.py Signed-off-by: Huy Vu <86480512+huvunvidia@users.noreply.github.com> --------- Signed-off-by: huvunvidia <huvunvidia@users.noreply.github.com> Signed-off-by: Huy Vu <86480512+huvunvidia@users.noreply.github.com> Co-authored-by: Huy Vu2 <huvu@login-eos01.eos.clusters.nvidia.com> Co-authored-by: huvunvidia <huvunvidia@users.noreply.github.com> Signed-off-by: Amir Hussein <amhussein@nvidia.com>

* fix QA comments NVBug: NVBug link: https://nvbugspro.nvidia.com/bug/5381026 * Apply isort and black reformatting Signed-off-by: huvunvidia <huvunvidia@users.noreply.github.com> * Update avlm_generate.py Signed-off-by: Huy Vu <86480512+huvunvidia@users.noreply.github.com> * Update avlm_nemo_run.py Signed-off-by: Huy Vu <86480512+huvunvidia@users.noreply.github.com> * Update avlm_nemo_run.py Signed-off-by: Huy Vu <86480512+huvunvidia@users.noreply.github.com> --------- Signed-off-by: huvunvidia <huvunvidia@users.noreply.github.com> Signed-off-by: Huy Vu <86480512+huvunvidia@users.noreply.github.com> Co-authored-by: Huy Vu2 <huvu@login-eos01.eos.clusters.nvidia.com> Co-authored-by: huvunvidia <huvunvidia@users.noreply.github.com>

* fix QA comments NVBug: NVBug link: https://nvbugspro.nvidia.com/bug/5381026 * Apply isort and black reformatting Signed-off-by: huvunvidia <huvunvidia@users.noreply.github.com> * Update avlm_generate.py Signed-off-by: Huy Vu <86480512+huvunvidia@users.noreply.github.com> * Update avlm_nemo_run.py Signed-off-by: Huy Vu <86480512+huvunvidia@users.noreply.github.com> * Update avlm_nemo_run.py Signed-off-by: Huy Vu <86480512+huvunvidia@users.noreply.github.com> --------- Signed-off-by: huvunvidia <huvunvidia@users.noreply.github.com> Signed-off-by: Huy Vu <86480512+huvunvidia@users.noreply.github.com> Co-authored-by: Huy Vu2 <huvu@login-eos01.eos.clusters.nvidia.com> Co-authored-by: huvunvidia <huvunvidia@users.noreply.github.com> Signed-off-by: Guyue Huang <guyueh@nvidia.com>

fix QA comments NVBug

961dcf0

huvunvidia added the Run CICD label Jul 11, 2025

Apply isort and black reformatting

d751e33

Signed-off-by: huvunvidia <huvunvidia@users.noreply.github.com>

ko3n1g added Run CICD and removed Run CICD labels Jul 11, 2025

github-actions bot removed the Run CICD label Jul 11, 2025

github-advanced-security bot found potential problems Jul 11, 2025

View reviewed changes

scripts/avlm/avlm_generate.py Fixed Show fixed Hide fixed

scripts/avlm/avlm_nemo_run.py Fixed Show fixed Hide fixed

huvunvidia added 2 commits July 11, 2025 11:19

Update avlm_generate.py

6506ce2

Signed-off-by: Huy Vu <86480512+huvunvidia@users.noreply.github.com>

Update avlm_nemo_run.py

f91f30e

Signed-off-by: Huy Vu <86480512+huvunvidia@users.noreply.github.com>

github-advanced-security bot found potential problems Jul 11, 2025

View reviewed changes

scripts/avlm/avlm_nemo_run.py Fixed Show fixed Hide fixed

Update avlm_nemo_run.py

2a7289e

Signed-off-by: Huy Vu <86480512+huvunvidia@users.noreply.github.com>

huvunvidia added the Run CICD label Jul 11, 2025

github-actions bot removed the Run CICD label Jul 11, 2025

huvunvidia enabled auto-merge (squash) July 11, 2025 16:05

yashaswikarnati reviewed Jul 11, 2025

View reviewed changes

yashaswikarnati approved these changes Jul 11, 2025

View reviewed changes

huvunvidia merged commit 3e4012a into main Jul 11, 2025
55 checks passed

huvunvidia deleted the huvu/avlm_model_qafix branch July 11, 2025 16:08

yashaswikarnati reviewed Jul 11, 2025

View reviewed changes

huvunvidia mentioned this pull request Jul 16, 2025

Huvu/avlm qafix cherrypick from #14253

Merged

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix QA comments NVBug #14196

fix QA comments NVBug #14196

Uh oh!

huvunvidia commented Jul 11, 2025

Uh oh!

github-actions bot commented Jul 11, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jul 11, 2025

Uh oh!

yashaswikarnati Jul 11, 2025

Uh oh!

Uh oh!

yashaswikarnati Jul 11, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

fix QA comments NVBug #14196

fix QA comments NVBug #14196

Uh oh!

Conversation

huvunvidia commented Jul 11, 2025

What does this PR do ?

Changelog

Usage

GitHub Actions CI

Before your PR is "Ready for review"

Who can review?

Additional Information

Uh oh!

github-actions bot commented Jul 11, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jul 11, 2025

Uh oh!

yashaswikarnati Jul 11, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

yashaswikarnati Jul 11, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants